Ensure QuartzDatabaseInitializer is initialized before Scheduler
#9411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If auto-configured `Scheduler` instance backed by JDBC job store is used as a dependency in an application component, the initialization of `Scheduler` will be triggered before `QuartzDatabaseInitializer`. This will result in failure due to schema not being prepared in time for `Scheduler` to populate job details. This commit ensures `QuartzDatabaseInitializer` is initialized before auto-configured `Scheduler` by introducing a dependency between the two.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks! |
philwebb
added
priority: normal
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Jun 6, 2017
If the auto-configured `Scheduler` instance backed by JDBC job store is used as a dependency in an application component, the initialization of `Scheduler` will be triggered before `QuartzDatabaseInitializer`. This will result in failure due to schema not being prepared in time for `Scheduler` to populate job details. This commit ensures `QuartzDatabaseInitializer` is initialized before the auto-configured `Scheduler` by introducing a dependency between the two. See gh-9411
snicoll
added a commit
that referenced
this pull request
Jun 6, 2017
* pr/9411: Polish contribution Ensure `QuartzDatabaseInitializer` is initialized before `Scheduler`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If auto-configured
Schedulerinstance backed by JDBC job store is used as a dependency in an application component, the initialization ofSchedulerwill be triggered beforeQuartzDatabaseInitializer. This will result in failure due to schema not being prepared in time forSchedulerto populate job details.I've missed to pay attention to this in #4299 but it is a very common use case with Quartz.
This PR ensures
QuartzDatabaseInitializeris initialized before auto-configuredSchedulerby introducing a dependency between the two.I've also updated the tests as well as sample app to include this scenario. @snicoll Please review this and let me know what are your thoughts on the proposed changes.