Remove Jaxb annotations #695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregturn
force-pushed
the
bug/handle-browser
branch
from
e2833c1 to
96ad57e
Compare
gregturn
added a commit
that referenced
this pull request
Feb 1, 2018
By removing all Jaxb annotations, subimtted a request for a hypermedia enabled endpoint inside a browser (which defaults to accept:application/xhtml+xml,*/*), Spring HATEOAS will yield HAL.
gregturn
force-pushed
the
bug/handle-browser
branch
from
96ad57e to
b2ad3f6
Compare
gregturn
added a commit
that referenced
this pull request
Dec 5, 2018
By removing all Jaxb annotations, subimtted a request for a hypermedia enabled endpoint inside a browser (which defaults to accept:application/xhtml+xml,*/*), Spring HATEOAS will yield HAL.
By removing all Jaxb annotations, requesting data from a hypermedia-enabled endpoint inside a browser (which defaults to accept:application/xhtml+xml,*/*), Spring HATEOAS will yield HAL.
gregturn
force-pushed
the
bug/handle-browser
branch
from
b2ad3f6 to
b4d28e5
Compare
|
@schauder This PR pulls out XML support. Given our HAL format and others never did support XML, and having XML stuff actually confused Spring MVC routes, it makes sense to pull this stuff. |
Removed Jaxb annotations from packaga-info.java. Simplified Test code by removing unused code a debug output. Formatting.
schauder
approved these changes
Dec 6, 2018
| /** | ||
| * Verify the default {@literal Accept} header used by a browser (which favors XML/HTML) still yields HAL-JSON. | ||
| */ | ||
| @Test |
There was a problem hiding this comment.
Include a comment referencing an issue in the test or don't you do that for this project?
Applies to all @Test annotations.
Also applies to many other classes not touched in this commit.
Maybe cleaning this up an moving to the style of Spring Data is in place?
There was a problem hiding this comment.
Indeed, Spring HATEOAS observes the Spring Data standards, so using the notation is a good point.
gregturn
added a commit
that referenced
this pull request
Dec 6, 2018
By removing all Jaxb annotations, requesting data from a hypermedia-enabled endpoint inside a browser (which defaults to accept:application/xhtml+xml,*/*), Spring HATEOAS will yield HAL.
gregturn
pushed a commit
that referenced
this pull request
Dec 6, 2018
* Removed Jaxb annotations from packaga-info.java. * Simplified Test code by removing unused code a debug output. * Formatting. * Updated copyright headers.
|
Resolved via dca65e1. |
This was referenced Mar 5, 2019
This was referenced Mar 5, 2019
emerson-matos
added a commit
to emerson-matos/financasapi
that referenced
this pull request
Jul 20, 2020
[spring-hateoas source](spring-projects/spring-hateoas#119 (comment)) PR [#695](spring-projects/spring-hateoas#695) Signed-off-by: Emerson Almeida Matos <[email protected]>
emerson-matos
added a commit
to emerson-matos/financasapi
that referenced
this pull request
Jul 24, 2020
[spring-hateoas source](spring-projects/spring-hateoas#119 (comment)) PR [#695](spring-projects/spring-hateoas#695) Signed-off-by: Emerson Almeida Matos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.