Gh 4939 helloworld #4942
Merged
Gh 4939 helloworld #4942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a suggestion how to migrate the GebSpec based tests to Java / Selenium based tests. Issue: spring-projectsgh-4939
rwinch
added
in: build
|
Thanks for the PR @michael-simons! I have merged the changes into master. I'd love to see more PRs like this through the other Groovy tests. One thing that would be good is to please comment to indicate what portion you are working on to avoid duplicated efforts from other contributors. |
|
Thanks for the feedback! I just can comment on the original ticket when I start another. |
|
PS: I updated the original ticket to request people comment on it. I probably should have done that in the first place. Thanks again for your contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion how I would migrate the (nice) GebTests. While lucking through other tests, I noticed that the naming conventions differ throughout various samples. I opted for the same package and class names as in the old ones.
If this is useful, I can work my way throughout the others while my time permits.
See #4939