Skip to content

Migrate LDAP integration tests groovy->java #7691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

Migrate LDAP integration tests groovy->java #7691

merged 1 commit into from
Jan 13, 2020

Conversation

ghostd
Copy link
Contributor

@ghostd ghostd commented Dec 1, 2019

This commit also removes BaseSpringSpec

Issue: gh-4939

@pivotal-issuemaster
Copy link

@ghostd Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 1, 2019
@pivotal-issuemaster
Copy link

@ghostd Thank you for signing the Contributor License Agreement!

@eleftherias eleftherias self-assigned this Dec 2, 2019
eleftherias
eleftherias suggested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ghostd!
Please add the license header to all of the new tests classes. For more information on the header see https://github.com/spring-projects/spring-security/blob/master/CONTRIBUTING.md#add-apache-license-header-to-all-new-classes

@ghostd ghostd force-pushed the gh-4939-ldap-integration-tests branch from 66c5a50 to 2c7b118 Compare December 2, 2019 18:16
@ghostd
Copy link
Contributor Author

ghostd commented Dec 2, 2019

Hi @eleftherias

I fixed it

Regards

@ghostd ghostd requested a review from eleftherias December 3, 2019 06:45
eleftherias
eleftherias suggested changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ghostd!
I've left some comments inline.
In summary, we should not need the base class LdapBaseSpring.
I have referenced some commits with examples on how to migrate without using the base class.

@eleftherias eleftherias added in: ldap An issue in spring-security-ldap status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 12, 2019
@ghostd ghostd requested a review from eleftherias December 15, 2019 21:01
eleftherias
eleftherias suggested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @ghostd.
I have left some more comments inline.

@ghostd ghostd requested a review from eleftherias December 22, 2019 17:46
eleftherias
eleftherias suggested changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghostd. I have left some more comments.

eleftherias
eleftherias suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ghostd!
I have some additional comments inline.

@ghostd ghostd force-pushed the gh-4939-ldap-integration-tests branch 2 times, most recently from 9a8ff17 to db6e656 Compare January 9, 2020 16:51
@ghostd ghostd requested a review from eleftherias January 9, 2020 16:58
eleftherias
eleftherias suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghostd I have left one comment about the indentation, and after that we will be able to merge this PR.

@ghostd ghostd force-pushed the gh-4939-ldap-integration-tests branch from db6e656 to 299ccf9 Compare January 10, 2020 12:14
@ghostd ghostd requested a review from eleftherias January 10, 2020 12:53
eleftherias
eleftherias suggested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghostd I apologize, I don't think my last comment was clear about the indentation.
I have left another comment clarifying.

@ghostd
Migrate LDAP integration tests groovy->java
f458e30 
This commit also removes BaseSpringSpec

Issue: spring-projectsgh-4939
@ghostd ghostd force-pushed the gh-4939-ldap-integration-tests branch from 299ccf9 to f458e30 Compare January 13, 2020 11:46
@ghostd ghostd requested a review from eleftherias January 13, 2020 11:47
@eleftherias eleftherias merged commit f0856c8 into spring-projects:master Jan 13, 2020
@eleftherias eleftherias added this to the 5.3.0.RC1 milestone Jan 13, 2020
@eleftherias
Copy link
Contributor

Thanks for all your effort on this @ghostd! It is now merged into master.

@eleftherias eleftherias added type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias Awaiting requested review from eleftherias

Assignees

@eleftherias eleftherias

Labels
in: ldap An issue in spring-security-ldap type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.0.RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@ghostd @pivotal-issuemaster @eleftherias @spring-projects-issues