Skip to content

Register commands dynamically #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Feb 25, 2022 · 0 comments · Fixed by #381
Closed

Register commands dynamically #379

jvalkeal opened this issue Feb 25, 2022 · 0 comments · Fixed by #381
Milestone
2.1.0-M4

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Feb 25, 2022 •
edited
Loading

It'd be nice if we could handle command registrations dynamically when shell is running. We could start with something simple like allow add/remove commands from a CommandRegistry.
@jvalkeal jvalkeal mentioned this issue Feb 25, 2022
Closed
@jvalkeal jvalkeal added this to the 2.1.0-M4 milestone Feb 26, 2022
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Feb 26, 2022
@jvalkeal
Add dynamic command registration
9a563fc 
- Extend CommandRegistry for add/remove methods.
- For rest of shell classes move to use registry
  directly instead of caching commands as registry
  is not immutable anymore.
- Add new sample
- Fixes spring-projects#379
@jvalkeal jvalkeal mentioned this issue Feb 26, 2022
Merged
jvalkeal added a commit that referenced this issue Feb 26, 2022
@jvalkeal
Add dynamic command registration
7b547e5 
- Extend CommandRegistry for add/remove methods.
- For rest of shell classes move to use registry
  directly instead of caching commands as registry
  is not immutable anymore.
- Add new sample
- Fixes #379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0-M4
Development

Successfully merging a pull request may close this issue.

Add dynamic command registration jvalkeal/spring-shell
1 participant
@jvalkeal