Skip to content

Converters are not called #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ivangfr opened this issue Feb 15, 2023 · 1 comment
Closed

Converters are not called #667

ivangfr opened this issue Feb 15, 2023 · 1 comment
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/bug Is a bug report
Milestone
3.1.0-M1

Comments

@ivangfr
Copy link

ivangfr commented Feb 15, 2023

Hi guys, I've recently upgrade this project spring-webflux-reactive-databases that uses spring-shell to spring-boot 2.7.8 and spring-shell 2.1.6.

However, I've noticed that my converter CreateOrderProductConverter is not called.

The CreateOrderProductConverter is used here to convert a String with format "<product-1-id:quantity>[;<product-n-id:quantity>]" to Set<CreateOrderRequest.ProductDto>

If I downgrade to spring-shell 2.1.5, it works. Thanks!
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Feb 15, 2023
@jvalkeal jvalkeal added type/bug Is a bug report and removed status/need-triage Team needs to triage and take a first look labels Feb 17, 2023
@jvalkeal
Copy link
Contributor

Thanks reporting this. Must be regression in fixes made for options handling.

@jvalkeal jvalkeal changed the title Converters are not called in version 2.1.6 Converters are not called Feb 17, 2023
@jvalkeal jvalkeal added this to the 3.1.0-M1 milestone Feb 17, 2023
@jvalkeal jvalkeal added for/backport For backporting branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch labels Feb 17, 2023
This was referenced Feb 17, 2023
Closed
Closed
jvalkeal added a commit that referenced this issue Feb 18, 2023
@jvalkeal
Use correct type with set
e469c14 
- When target is set and only one option argument is given,
  we should not convert to list as user expects string to xxx
  Converter to work.
- This is how it used to work and previous changes caused
  regression.
- Bug is actually in an old parser and new parser works fine.
- Backport #667
- Fixes #670
jvalkeal added a commit that referenced this issue Feb 18, 2023
@jvalkeal
Use correct type with set
7ec5c19 
- When target is set and only one option argument is given,
  we should not convert to list as user expects string to xxx
  Converter to work.
- This is how it used to work and previous changes caused
  regression.
- Bug is actually in an old parser and new parser works fine.
- Backport #667
- Fixes #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch for/backport For backporting type/bug Is a bug report
Projects
None yet
Milestone
3.1.0-M1
Development

No branches or pull requests
2 participants
@jvalkeal @ivangfr