Skip to content

backport(667): Converters are not called #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Feb 17, 2023 · 0 comments
Closed

backport(667): Converters are not called #669

github-actions bot opened this issue Feb 17, 2023 · 0 comments
Labels
branch/2.1.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx
Milestone
2.1.7

Comments

@github-actions
Copy link
Contributor

Backport #667
@github-actions github-actions bot added branch/2.1.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx labels Feb 17, 2023
@jvalkeal jvalkeal added this to the 2.1.7 milestone Feb 17, 2023
jvalkeal added a commit that referenced this issue Feb 18, 2023
@jvalkeal
Use correct type with set
7ec5c19 
- When target is set and only one option argument is given,
  we should not convert to list as user expects string to xxx
  Converter to work.
- This is how it used to work and previous changes caused
  regression.
- Bug is actually in an old parser and new parser works fine.
- Backport #667
- Fixes #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/2.1.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx
Projects
None yet
Milestone
2.1.7
Development

No branches or pull requests
1 participant
@jvalkeal