Skip to content

Support @WithStateMachine with builders #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue May 13, 2016 · 1 comment
Closed

Support @WithStateMachine with builders #224

jvalkeal opened this issue May 13, 2016 · 1 comment
Labels
type/enhancement Is an enhancement request
Milestone
1.2.1.RELEASE

Comments

@jvalkeal
Copy link
Contributor

Machines created via @EnableStateMachineFactory or manually build are not registered as beans so @WithStateMachine doesn't resolve to any matching machine. Originally this support would have been impossible but a while back we added an id to StateMachine which is in user's disposal. As this id can be set via factory or manual builder, we might be able to centrally register those machines to somewhere(or allow user to do it manually) so that annotation handler could match machines from there.
@jvalkeal jvalkeal added the type/enhancement Is an enhancement request label May 13, 2016
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Sep 30, 2016
@jvalkeal
Fix StateMachineHandler method caching
27d67bf 
- Adding ApplicationListener so that we can
  consult time of last ContextRefreshedEvent and
  rebuild a cache of StateMachineHandler methods.
- This implementation is a bit naive as we speak but
  work for spring-projects#224 will need to add better concept to work
  outside of app context.
- Fixes spring-projects#232
@sanoprime sanoprime mentioned this issue Dec 7, 2016
Closed
@jvalkeal jvalkeal added this to the 1.2.1.RELEASE milestone Dec 10, 2016
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Jan 10, 2017
@jvalkeal
@WithStateMachine with factory and builder
48b694f 
- Add support so that @WithStateMachine can be used with
  machines build via @EnableStateMachineFactory or via
  manual builders.
- Adding new annotation @EnableWithStateMachine to help
  handling needed context configuration.
- Add tests and docs.
- Fixes spring-projects#292
- Fixes spring-projects#224
@jvalkeal jvalkeal mentioned this issue Jan 10, 2017
Merged
@jvalkeal
Copy link
Contributor Author

Fixed in 1.2.x

@jvalkeal jvalkeal mentioned this issue Jan 18, 2017
Closed
23 tasks
jvalkeal added a commit that referenced this issue Jan 18, 2017
@jvalkeal
@WithStateMachine with factory and builder
29e8cdd 
- Backport #292
- Backport #224
- Add support so that @WithStateMachine can be used with
  machines build via @EnableStateMachineFactory or via
  manual builders.
- Adding new annotation @EnableWithStateMachine to help
  handling needed context configuration.
- Add tests and docs.
- Relates to #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Is an enhancement request
Projects
None yet
Milestone
1.2.1.RELEASE
Development

No branches or pull requests
1 participant
@jvalkeal