Skip to content

Backport 1.2.x changes for 2.0.0.M1 #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
23 tasks done
jvalkeal opened this issue Jan 18, 2017 · 0 comments
Closed
23 tasks done

Backport 1.2.x changes for 2.0.0.M1 #307

jvalkeal opened this issue Jan 18, 2017 · 0 comments
Labels
for/backport For backporting
Milestone
2.0.0.M1

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Jan 18, 2017 •
edited
Loading

Issue to track needed backports from branch 1.2.x into master.
@jvalkeal jvalkeal added the for/backport For backporting label Jan 18, 2017
@jvalkeal jvalkeal added this to the 2.0.0.M1 milestone Jan 18, 2017
jvalkeal added a commit that referenced this issue Jan 18, 2017
@jvalkeal
Make autostart smarter
17d977d 
- Backport #298
- Factory now listens machine event if autostart
  is requested which should give fully started machine
  i.e. if asynch executor is used. Bails out after 30
  seconds. Further tweaks like allowing user to define
  this time or conditionally not wait could be added later.
- Fix typos.
- Relates to #307
jvalkeal added a commit that referenced this issue Jan 18, 2017
@jvalkeal
@WithStateMachine with factory and builder
29e8cdd 
- Backport #292
- Backport #224
- Add support so that @WithStateMachine can be used with
  machines build via @EnableStateMachineFactory or via
  manual builders.
- Adding new annotation @EnableWithStateMachine to help
  handling needed context configuration.
- Add tests and docs.
- Relates to #307
jvalkeal added a commit that referenced this issue Feb 10, 2017
@jvalkeal
Better generics handling with adapters
90637d6 
- Modify StateMachineConfiguration and StateMachineFactoryConfiguration
  so that if you have different states and events classes with multiple
  machines or factories, you can autowire by types without
  adding qualifiers.
- Manually try to discover generic types from enclosing adapther class
  and if succesfull pass that information into bean definition
  as ResolvableType.
- Backporting #306
- Relates to #307
jvalkeal added a commit that referenced this issue Mar 9, 2017
@jvalkeal
Timer trigger deadlock in DefaultStateMachineExecutor
7371f67 
- Add new tests for DefaultStateMachineExecutor to find
  possible causes for a deadlock.
- Handle lifecycle scenario little differently
  if timer is fired during a executor starting phase
  order to not getting into a deadlock.
- Backport #315
- Relates to #307
jvalkeal added a commit that referenced this issue Mar 9, 2017
@jvalkeal
Support Connection Point References
6e64797 
- Add support to uml parser to properly
  detect and use exit/entry points if those
  are used via connection ref points with
  submachine references.
- Backport #323
- Relates to #307
jvalkeal added a commit that referenced this issue Mar 9, 2017
@jvalkeal
Notify transition before calling its actions
688b61d 
- Add new api to Transition to expose calling
  its actions.
- Modify rest of a framework to first notify before
  calling transtion action.
- Backport #322
- Relates to #307
jvalkeal added a commit that referenced this issue Mar 9, 2017
@jvalkeal
Disarm timers
6ced037 
- Trying to handle scenario where TimerTrigger keeps firing
  even if machine is stopped or has moved away from its
  hosting state.
- Explicitely handle trigger starts/stops in
  DefaultStateMachineExecutor when executor itself
  is started/stopped.
- Backport #321
- Relates to #307
@jvalkeal jvalkeal changed the title Backport 1.2.x changes Backport 1.2.x changes for 2.0.0.M1 May 5, 2017
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue May 5, 2017
@jvalkeal
StateMachineContextSerializer handles history and id
c4af0e7 
- Add missing serialisation for history map and machine id
- Fix possible NPE with extended state
- Backport spring-projects#331
- Backport spring-projects#333
- Relates spring-projects#307
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue May 5, 2017
@jvalkeal
Prevent debug calls
331dc05 
- Polish to do checks for debug/trace logs
- Backport spring-projects#329
- Relates spring-projects#307
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue May 5, 2017
@jvalkeal
Fix action error in anonymous transition
d3b6491 
- Executor is following anonymous transitions in a loop
  and if there is an exception in actions with this transition,
  effectively executor ended into infinite loop.
- No bailing out from this loop if we cannot continue.
- Backport spring-projects#344
- Relates spring-projects#307
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue May 5, 2017
@jvalkeal
Fix post interceptor call
d16e29e 
- Now calling post state interceptor with
  correct/same state as pre.
- Backport spring-projects#353
- Relates spring-projects#307
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue May 5, 2017
@jvalkeal
Support actions with transition via choice/junction pseudostate
3884d48 
- Adding support for javaconfig/uml to define
  actions for transitions leading out from a
  choice or junction states.
- Support for action for incoming transition is
  already implemented as it is defined as normal
  transition.
- Backport spring-projects#108
- Relates spring-projects#307
jvalkeal added a commit that referenced this issue May 19, 2017
@jvalkeal
NPE on sendEvent
8d7fe80 
- Adding null check for current state
- Remove synchronization from scheduleEventQueueProcessing
  method in executor. Looks like this sync is not really needed
  and indeed may cause jvm level deadlocks if threads are used
  for execution.
- Change how some internals in
  AbstractStateMachine are synchronized
  to limit changes for deadlock.
- Relates to #307
- Backport of #359 #360
jvalkeal added a commit that referenced this issue Jul 9, 2017
@jvalkeal
@WithStateMachine may register too many processors
526c05e 
- Change processor registration so that if @WithStateMachine is
  used with 'id', 'name' is skipped because it defaults to 'stateMachine'
  and would cause extra registration.
- Relates #307
- Backport #370
jvalkeal added a commit that referenced this issue Jul 9, 2017
@jvalkeal
Add support for multiple end states with javaconfig
1e60b7a 
- Add missing support for defining more than one
  end states and as it's just missing from javaconfig.
- Backport #368
- Relates #307
jvalkeal added a commit that referenced this issue Jul 9, 2017
@jvalkeal
Fix OnExtendedStateChanged with key
f268999 
- Fix case where method was annotated with
  @OnExtendedStateChanged(key = "V1"), V1 was
  changed which didn't result call to that method.
- Backport #387
- Relates #307
jvalkeal added a commit that referenced this issue Jul 9, 2017
@jvalkeal
Add recursive context build
6b636be 
- Fix AbstractStateMachinePersister to handle
  recursive machines and regions.
- Backport #391
- Relates #307
jvalkeal added a commit that referenced this issue Jul 9, 2017
@jvalkeal
Change machine lifecycle with restore
0753f71 
- Fixing machine lifecycle logic when machine
  is restored which effectively should not touch
  any lifecycle methods as start/stop is
  user level action.
- Remove start/stop from restore and attempt to
  do same when root machine is started. This also
  needed some further changes as some functionality
  for restore was essentially broken
- Backport #386
- Relates #307
jvalkeal added a commit that referenced this issue Jul 9, 2017
@jvalkeal
Clear machine id with null context restore
6fc08b5 
- As passing in null context don't have any
  meaning other than doing reset with pre-defined
  behaviour which currently just resets back to
  initial state and clears extended state variables.
  Now Also clearing machine id back to null which is
  anyway a default value.
- Backport #381
- Relates #307
jvalkeal pushed a commit that referenced this issue Nov 12, 2017
@pinguet62 @jvalkeal
Fix logging message when transition action throws exception
fb8d534 
- Backport #413
- Relates #307
jvalkeal added a commit that referenced this issue Nov 12, 2017
@jvalkeal
Fix state holder usage
10ed7fe 
- In AbstractStateMachineFactory change used holder map
  to list so that same states don't get lost because of
  used key.
- Backport #416
- Relates #307
jvalkeal added a commit that referenced this issue Nov 12, 2017
@jvalkeal
Handle null BeanFactory in StateMachineHandlerCallHelper
c2db915 
- Makes things less chatty if BeanFactory is null in
  StateMachineHandlerCallHelper as this is usually a case
  with manual builders outside of app context.
- Backport #412
- Relates #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for/backport For backporting
Projects
None yet
Milestone
2.0.0.M1
Development

No branches or pull requests
1 participant
@jvalkeal