Skip to content

Notify transition before calling its actions #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tarioch opened this issue Feb 28, 2017 · 1 comment
Closed

Notify transition before calling its actions #322

tarioch opened this issue Feb 28, 2017 · 1 comment
Labels
type/bug Is a bug report
Milestone
1.2.3.RELEASE

Comments

@tarioch
Copy link
Contributor

tarioch commented Feb 28, 2017

Currently

  1. action is executed
  2. transitionStarted
  3. transitionEnded

Expected

  1. transitionStarted
  2. action is executed
  3. transitionEnded
@jvalkeal jvalkeal changed the title Change Order of calls to StateMachineListener on transition Notify transition before calling its actions Mar 7, 2017
@jvalkeal jvalkeal added the type/bug Is a bug report label Mar 7, 2017
@jvalkeal jvalkeal added this to the 1.2.3.RELEASE milestone Mar 7, 2017
@jvalkeal jvalkeal mentioned this issue Mar 7, 2017
Closed
23 tasks
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Mar 7, 2017
@jvalkeal
Notify transition before calling its actions
5f8e6c0 
- Add new api to Transition to expose calling
  its actions.
- Modify rest of a framework to first notify before
  calling transtion action.
- Fixes spring-projects#322
@jvalkeal jvalkeal mentioned this issue Mar 7, 2017
Merged
@jvalkeal
Copy link
Contributor

jvalkeal commented Mar 7, 2017

Merged per 5f8e6c0

@jvalkeal jvalkeal closed this as completed Mar 7, 2017
jvalkeal added a commit that referenced this issue Mar 9, 2017
@jvalkeal
Notify transition before calling its actions
688b61d 
- Add new api to Transition to expose calling
  its actions.
- Modify rest of a framework to first notify before
  calling transtion action.
- Backport #322
- Relates to #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Is a bug report
Projects
None yet
Milestone
1.2.3.RELEASE
Development

No branches or pull requests
2 participants
@jvalkeal @tarioch