Skip to content

StateMachineContextSerializer may throw NPE #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Mar 20, 2017 · 1 comment
Closed

StateMachineContextSerializer may throw NPE #331

jvalkeal opened this issue Mar 20, 2017 · 1 comment
Labels
type/bug Is a bug report
Milestone
1.2.4.RELEASE

Comments

@jvalkeal
Copy link
Contributor

There's no check if extended state is null per

kryo.writeClassAndObject(output, context.getExtendedState().getVariables());

Need to check against npe and why extended state was null when I did some testing with redis persistence.
@jvalkeal jvalkeal added the type/bug Is a bug report label Mar 20, 2017
@jvalkeal jvalkeal added this to the 1.2.4.RELEASE milestone Mar 20, 2017
@jvalkeal jvalkeal mentioned this issue Mar 21, 2017
Closed
23 tasks
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Mar 21, 2017
@jvalkeal
StateMachineContextSerializer handles history and id
f7a93a7 
- Add missing serialisation for history map and machine id
- Fix possible NPE with extended state
- Fixes spring-projects#331
- Fixes spring-projects#333
@jvalkeal jvalkeal mentioned this issue Mar 21, 2017
Merged
@jvalkeal
Copy link
Contributor Author

Merged per f7a93a7

jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue May 5, 2017
@jvalkeal
StateMachineContextSerializer handles history and id
c4af0e7 
- Add missing serialisation for history map and machine id
- Fix possible NPE with extended state
- Backport spring-projects#331
- Backport spring-projects#333
- Relates spring-projects#307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Is a bug report
Projects
None yet
Milestone
1.2.4.RELEASE
Development

No branches or pull requests
1 participant
@jvalkeal