Skip to content

Deadlock in executor #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue May 15, 2017 · 0 comments
Closed

Deadlock in executor #360

jvalkeal opened this issue May 15, 2017 · 0 comments
Labels
type/bug Is a bug report
Milestone
1.2.5.RELEASE

Comments

@jvalkeal
Copy link
Contributor

Original issue in #359 as Deadlock when using StateMachineTestPlan
@jvalkeal jvalkeal added the type/bug Is a bug report label May 15, 2017
@jvalkeal jvalkeal added this to the 1.2.5.RELEASE milestone May 15, 2017
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue May 15, 2017
@jvalkeal
Handle possible deadlock
4d98b80 
- Remove synchronization from scheduleEventQueueProcessing
  method in executor. Looks like this sync is not really needed
  and indeed may cause jvm level deadlocks if threads are used
  for execution.
- Fixes spring-projects#360
This was referenced May 15, 2017
Closed
Closed
jvalkeal added a commit that referenced this issue May 19, 2017
@jvalkeal
NPE on sendEvent
8d7fe80 
- Adding null check for current state
- Remove synchronization from scheduleEventQueueProcessing
  method in executor. Looks like this sync is not really needed
  and indeed may cause jvm level deadlocks if threads are used
  for execution.
- Change how some internals in
  AbstractStateMachine are synchronized
  to limit changes for deadlock.
- Relates to #307
- Backport of #359 #360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Is a bug report
Projects
None yet
Milestone
1.2.5.RELEASE
Development

No branches or pull requests
1 participant
@jvalkeal