Skip to content

Multiple exit points to same state fails #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Oct 28, 2017 · 0 comments
Closed

Multiple exit points to same state fails #416

jvalkeal opened this issue Oct 28, 2017 · 0 comments
Labels
type/bug Is a bug report
Milestone
1.2.7.RELEASE

Comments

@jvalkeal
Copy link
Contributor

Having something like this in transitions:

.withExit()
	.source("S2EXIT").target("S1")
	.and()
.withExit()
	.source("S3EXIT").target("S1");

is causing holder state in ExitPseudoState not getting set properly.

Bug is used Map<S, StateHolder<S, E>> holderMap in AbstractStateMachineFactory as holder get overridden because of map key. Need to change this to simple list.
@jvalkeal jvalkeal added the type/bug Is a bug report label Oct 28, 2017
@jvalkeal jvalkeal added this to the 1.2.7.RELEASE milestone Oct 28, 2017
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Oct 28, 2017
@jvalkeal
Fix state holder usage
c83b005 
- In AbstractStateMachineFactory change used holder map
  to list so that same states don't get lost because of
  used key.
- Fixes spring-projects#416
@jvalkeal jvalkeal mentioned this issue Oct 28, 2017
Closed
jvalkeal added a commit that referenced this issue Oct 28, 2017
@jvalkeal
Fix state holder usage
ab31c94 
- In AbstractStateMachineFactory change used holder map
  to list so that same states don't get lost because of
  used key.
- Fixes #416
@jvalkeal jvalkeal mentioned this issue Oct 28, 2017
Closed
23 tasks
jvalkeal added a commit that referenced this issue Nov 12, 2017
@jvalkeal
Fix state holder usage
10ed7fe 
- In AbstractStateMachineFactory change used holder map
  to list so that same states don't get lost because of
  used key.
- Backport #416
- Relates #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Is a bug report
Projects
None yet
Milestone
1.2.7.RELEASE
Development

No branches or pull requests
1 participant
@jvalkeal