Skip to content

Conversation

hf
Copy link
Contributor

@hf hf commented Aug 4, 2025

If you set GOTRUE_EXTERNAL_<PROVIDER>_EMAIL_OPTIONAL=true then OAuth, OIDC sign-in with that provider will no longer enforce that an email address is present.

Adds some fixes to the Snapchat provider per internal discussions.

@hf hf requested a review from a team as a code owner August 4, 2025 12:19
@hf hf force-pushed the hf/email-less-accounts-with-oauth branch 2 times, most recently from 2508d74 to d99e5f2 Compare August 5, 2025 17:26
@hf hf force-pushed the hf/email-less-accounts-with-oauth branch from 61af757 to 4308bc2 Compare August 18, 2025 09:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17036678689

Details

  • 82 of 127 (64.57%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 70.757%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/samlacs.go 0 1 0.0%
internal/api/context.go 12 14 85.71%
internal/api/provider/oidc.go 0 2 0.0%
internal/api/external_oauth.go 4 7 57.14%
internal/api/external.go 61 69 88.41%
internal/api/token_oidc.go 2 15 13.33%
internal/api/provider/snapchat.go 1 17 5.88%
Files with Coverage Reduction New Missed Lines %
internal/api/external.go 1 75.63%
Totals Coverage Status
Change from base Build 16805096183: -0.07%
Covered Lines: 12258
Relevant Lines: 17324

💛 - Coveralls

@hf hf merged commit 9a61dae into master Aug 18, 2025
6 checks passed
@hf hf deleted the hf/email-less-accounts-with-oauth branch August 18, 2025 15:43
hf pushed a commit that referenced this pull request Aug 28, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.179.0](v2.178.0...v2.179.0)
(2025-08-28)


### Features

* add oauth2 client support
([#2098](#2098))
([8fae015](8fae015))
* experimental own linking domains per provider
([#2119](#2119))
([747bf3b](747bf3b))
* fetch email from snapchat oauth provider if available for consistency
([#2110](#2110))
([7507822](7507822))
* implement link identity with oidc / native sign in
([#2108](#2108))
([5f0ec87](5f0ec87))
* implements email-less accounts with oauth
([#2105](#2105))
([9a61dae](9a61dae))
* introduce request-scoped background tasks & async mail sending
([#2126](#2126))
([2c8ea61](2c8ea61))
* refactor mailer client wiring and add validation wrapper
([#2130](#2130))
([68c40a6](68c40a6))
* support multiple `aud` for the external providers
([#2117](#2117))
([ca5792e](ca5792e))
* use `slices.Contains` instead of for loops
([#2111](#2111))
([9f22682](9f22682))


### Bug Fixes

* add `id-token` permission to ci
([#2143](#2143))
([79209c0](79209c0))
* add missing param
([#2125](#2125))
([c0b75f6](c0b75f6))
* change s3 artifact upload role
([#2145](#2145))
([767e371](767e371))
* remove requirement of empty content-type on 204
([#2128](#2128))
([ecc97e0](ecc97e0))
* run release-please again
([#2144](#2144))
([2560f14](2560f14))
* stripped binary now includes version
([#2147](#2147))
([609f169](609f169))
* update copyright year in LICENSE
([#2142](#2142))
([67fe0b0](67fe0b0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants