Skip to content

Conversation

bnjmnt4n
Copy link
Contributor

@bnjmnt4n bnjmnt4n commented Aug 12, 2025

Use slices.Contains instead of manual loops. Some of these were suggested by the gopls language server, and I did a quick search of the codebase for similar patterns which could use the same.

@coveralls
Copy link

coveralls commented Aug 12, 2025

Pull Request Test Coverage Report for Build 17127921712

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 20 (80.0%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 70.817%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/token_oidc.go 5 7 71.43%
internal/models/sessions.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
internal/api/token_oidc.go 1 14.15%
internal/models/sessions.go 1 78.33%
Totals Coverage Status
Change from base Build 17127809662: -0.002%
Covered Lines: 12279
Relevant Lines: 17339

💛 - Coveralls

@bnjmnt4n bnjmnt4n marked this pull request as ready for review August 12, 2025 12:13
@bnjmnt4n bnjmnt4n requested a review from a team as a code owner August 12, 2025 12:13
@hf hf changed the title chore: use slices.Contains instead of for loops feat: use slices.Contains instead of for loops Aug 19, 2025
Some of these were suggested by the gopls language server, and I did
a quick search of the codebase for similar patterns which could be
converted to use `slices.Contains` as well.
@hf hf force-pushed the push-wnvwkqmwrrtk branch from 3ac88b6 to 2d89eda Compare August 19, 2025 08:43
@cemalkilic cemalkilic merged commit 9f22682 into supabase:master Aug 21, 2025
4 checks passed
hf pushed a commit that referenced this pull request Aug 28, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.179.0](v2.178.0...v2.179.0)
(2025-08-28)


### Features

* add oauth2 client support
([#2098](#2098))
([8fae015](8fae015))
* experimental own linking domains per provider
([#2119](#2119))
([747bf3b](747bf3b))
* fetch email from snapchat oauth provider if available for consistency
([#2110](#2110))
([7507822](7507822))
* implement link identity with oidc / native sign in
([#2108](#2108))
([5f0ec87](5f0ec87))
* implements email-less accounts with oauth
([#2105](#2105))
([9a61dae](9a61dae))
* introduce request-scoped background tasks & async mail sending
([#2126](#2126))
([2c8ea61](2c8ea61))
* refactor mailer client wiring and add validation wrapper
([#2130](#2130))
([68c40a6](68c40a6))
* support multiple `aud` for the external providers
([#2117](#2117))
([ca5792e](ca5792e))
* use `slices.Contains` instead of for loops
([#2111](#2111))
([9f22682](9f22682))


### Bug Fixes

* add `id-token` permission to ci
([#2143](#2143))
([79209c0](79209c0))
* add missing param
([#2125](#2125))
([c0b75f6](c0b75f6))
* change s3 artifact upload role
([#2145](#2145))
([767e371](767e371))
* remove requirement of empty content-type on 204
([#2128](#2128))
([ecc97e0](ecc97e0))
* run release-please again
([#2144](#2144))
([2560f14](2560f14))
* stripped binary now includes version
([#2147](#2147))
([609f169](609f169))
* update copyright year in LICENSE
([#2142](#2142))
([67fe0b0](67fe0b0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants