Document that context is not reactive. #3296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Jul 27, 2019
site/content/docs/03-run-time.md
Outdated
| </script> | ||
| ``` | ||
|
|
||
| > Context is not inherently reactive, if you need reactive values in context then you can pass a store into context, which *will* be reactive. |
There was a problem hiding this comment.
not, sure, what, you, mean.
There was a problem hiding this comment.
"In English grammar, a comma splice or comma fault is the use of a comma to join two independent clauses. For example: It is nearly half past five, we cannot reach town before dark."
There was a problem hiding this comment.
(In the other place you added this in the docs, you made it two completely separate sentences, which seems fine.)
There was a problem hiding this comment.
That makes sense, I thought it looked a bit weird. I've changed it to match the other one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this enough? Is this the right place?
I put it in both so that it is clear regardless of where you are looking. I don't think we need an example of passing store into context since it is just another value but maybe I'm wrong.
Closes #3271.