Skip to content

update readme #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 11, 2020
Merged

update readme #75

merged 8 commits into from
May 11, 2020

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented May 8, 2020

motivation: better and more up-to-date information

changes: rewrite readme to reflect APIs and architecture

motivation: better and more up-to-date information 

changes: rewrite readme to reflect APIs and architecture
@tomerd tomerd requested review from fabianfett and yim-lee May 8, 2020 00:06
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Added some minor notes

tomerd and others added 2 commits May 8, 2020 12:17
Co-authored-by: Konrad `ktoso` Malawski <[email protected]>

3. Deploy to AWS Lambda. To do so, you need to compile your Application for Amazon Linux 2, package it as a Zip file, and upload to AWS. Swift.org publishes [Swift toolchains and Docker images for Amazon Linux 2](https://swift.org/download/).

You can find complete sample build and deployment scripts in the [Examples Directory](/Examples)
Copy link
Member

@fabianfett fabianfett May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomerd If you want me to I could edit my current explanation for our new lambda. Then we have a manual walk-trough as well.

@tomerd
Copy link
Contributor Author

tomerd commented May 11, 2020

@fabianfett okay to merge?

Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits


6. In case of error, the library posts to AWS Lambda Runtime Engine `/error` endpoint to provide the error details, which will show up on AWS Lambda logs.
### AWS Lambda Runtime Engine Integration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this in the README? IMHO this is more or less a technical detail for developers who want to get involved. Maybe we want to add this to a /docs/Contributing.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it here, we do similar things in other projects as README is both for users and potential contributors


2. The library parses the response HTTP headers and populate the `Lambda.Context` object.
### Configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this belongs to Architecture or if it should be its own level 2 heading?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine, its at at the same level as other key entities like ByteBufferLambdaHandler etc

@tomerd tomerd merged commit 76b2332 into master May 11, 2020
@tomerd tomerd deleted the update-readme branch May 11, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants