-
Notifications
You must be signed in to change notification settings - Fork 113
update readme #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme #75
Conversation
motivation: better and more up-to-date information changes: rewrite readme to reflect APIs and architecture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Added some minor notes
Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
Co-authored-by: Fabian Fett <[email protected]>
|
||
3. Deploy to AWS Lambda. To do so, you need to compile your Application for Amazon Linux 2, package it as a Zip file, and upload to AWS. Swift.org publishes [Swift toolchains and Docker images for Amazon Linux 2](https://swift.org/download/). | ||
|
||
You can find complete sample build and deployment scripts in the [Examples Directory](/Examples) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomerd If you want me to I could edit my current explanation for our new lambda. Then we have a manual walk-trough as well.
@fabianfett okay to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits
|
||
6. In case of error, the library posts to AWS Lambda Runtime Engine `/error` endpoint to provide the error details, which will show up on AWS Lambda logs. | ||
### AWS Lambda Runtime Engine Integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this in the README
? IMHO this is more or less a technical detail for developers who want to get involved. Maybe we want to add this to a /docs/Contributing.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep it here, we do similar things in other projects as README is both for users and potential contributors
|
||
2. The library parses the response HTTP headers and populate the `Lambda.Context` object. | ||
### Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this belongs to Architecture
or if it should be its own level 2 heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine, its at at the same level as other key entities like ByteBufferLambdaHandler
etc
Co-authored-by: Fabian Fett <[email protected]>
motivation: better and more up-to-date information
changes: rewrite readme to reflect APIs and architecture