Skip to content

[Swift/Macros] Update for serialization change in Swift #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 16, 2023

Update for swiftlang/swift#66689
Plugin search options are now serialized as a single list of options paired with the kind.

Plugin search options are now serialized as a single list of options
paired with the kind.
@rintaro
Copy link
Member Author

rintaro commented Jun 16, 2023

swiftlang/swift#66689
@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jun 16, 2023

Hide whitespace for easier reviewing.

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please see my question on the paired Swift PR about exporting the enum used for the option rather than string matching here.

@rintaro
Copy link
Member Author

rintaro commented Jun 16, 2023

swiftlang/swift#66689
@swift-ci Please test

@rintaro rintaro force-pushed the macros-serialization-pluginopts branch from b6554f7 to 93d4f9b Compare June 16, 2023 19:08
@rintaro
Copy link
Member Author

rintaro commented Jun 16, 2023

swiftlang/swift#66689
@swift-ci Please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants