[Macros] Update plugin search options serialization #66689
Conversation
Previously plugin search options were serialized for each option kind. Instead serialize them in the order specified.
|
swiftlang/llvm-project#7003 |
| options_block::ResilienceStrategyLayout::readRecord(scratch, optKind); | ||
| switch (PluginSearchOptionKind(optKind)) { | ||
| case PluginSearchOptionKind::PluginPath: | ||
| optStr = "-plugin-path"; |
There was a problem hiding this comment.
Not sure about this. But I didn't want to introduce another "kind" enum just for swift/Serialization/Validation.h
There was a problem hiding this comment.
The fact that LLDB needs to match on these strings feels a little brittle. Would we be better off exporting PluginSearchOptionKind into a header and having that in the list of plugin search options?
There was a problem hiding this comment.
👍 Added a commit.
Made PluginSearchOption a struct with PluginSearchOption::Kind in SearchPathOptions.h
| options_block::ResilienceStrategyLayout::readRecord(scratch, optKind); | ||
| switch (PluginSearchOptionKind(optKind)) { | ||
| case PluginSearchOptionKind::PluginPath: | ||
| optStr = "-plugin-path"; |
There was a problem hiding this comment.
The fact that LLDB needs to match on these strings feels a little brittle. Would we be better off exporting PluginSearchOptionKind into a header and having that in the list of plugin search options?
| LoadPluginLibrary, | ||
| LoadPluginExecutable, | ||
| }; | ||
| using PluginSearchOptionKindField = BCFixed<3>; |
There was a problem hiding this comment.
It looks like a BCFixed<2> should be enough for the current enum size.
Create a 'Kind' enum so that deserialization can use the kind instead of a string option name.
rintaro
force-pushed
the
macros-serialization-pluginopts
branch
from
ec184e9 to
6fa0c14
Compare
|
swiftlang/llvm-project#7003 |
1 similar comment
|
swiftlang/llvm-project#7003 |
|
|
Previously plugin search options were serialized for each option kind. Instead serialize them in the order specified.
rdar://110903149