Allow macro expansions to be viewed through GetReferenceDocumentRequest instead of storing in temporary files
#1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Jul 17, 2024
Sources/LanguageServerProtocol/Requests/GetReferenceDocumentRequest.swift
Show resolved
Hide resolved
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
from
c9e559b to
58a1d7d
Compare
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
from
58a1d7d to
f49c429
Compare
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
from
f49c429 to
df712a5
Compare
|
@ahoppen I have updated the PR and fixed the rebase issue with package specifiers. Ready for full review now. 👍🏻 |
ahoppen
reviewed
Jul 25, 2024
Sources/SourceKitLSP/Swift/MacroExpansionReferenceDocument.swift
Outdated
Show resolved
Hide resolved
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
2 times, most recently
from
7f495e1 to
a8f496d
Compare
|
@ahoppen ready for review |
ahoppen
reviewed
Jul 26, 2024
Sources/SourceKitLSP/Swift/MacroExpansionReferenceDocumentURLData.swift
Outdated
Show resolved
Hide resolved
Sources/SourceKitLSP/Swift/MacroExpansionReferenceDocumentURLData.swift
Outdated
Show resolved
Hide resolved
Sources/SourceKitLSP/Swift/MacroExpansionReferenceDocumentURLData.swift
Outdated
Show resolved
Hide resolved
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
from
a8f496d to
c9f9d23
Compare
|
@ahoppen Ready for review. |
ahoppen
reviewed
Jul 29, 2024
Sources/SourceKitLSP/Swift/MacroExpansionReferenceDocumentURLData.swift
Outdated
Show resolved
Hide resolved
Sources/SourceKitLSP/Swift/MacroExpansionReferenceDocumentURLData.swift
Outdated
Show resolved
Hide resolved
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
2 times, most recently
from
87026f7 to
b6d9a02
Compare
lokesh-tr
commented
Jul 31, 2024
…est` instead of storing in temporary files
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
from
b6d9a02 to
0522e1a
Compare
|
@ahoppen Fixed everything as you suggested 🙂 |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the storage of temporary macro expansion files for
PeekDocumentsRequestby introducing a new LSP ExtensionGetReferenceDocumentRequest.The implementation is made in such a way that the URI passed for macro expansions through
PeekDocumentsRequestis customised with a new scheme, and expects the client to resolve the contents of this new URI by making aGetReferenceDocumentRequest.References:
Previous PR which implemented
PeekDocumentsRequest: #1479Accompanying PR in vscode-swift repository: swiftlang/vscode-swift#971
Expansion of Swift Macros in Visual Studio Code - Google Summer Of Code 2024
@lokesh-tr @ahoppen @adam-fowler