Retrieve macro expansions for PeekDocumentsRequest through GetReferenceDocumentRequest instead of showing temporary files
#971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Looks good, mainly looking to not make this macro specific because it could be used in other situations. @ahoppen perhaps this could be used for generated swiftinterface files
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
from
7e8bb7a to
4528b4a
Compare
…renceDocumentRequest` instead of showing temporary files
lokesh-tr
force-pushed
the
macro-expansions-get-reference-document
branch
from
4528b4a to
d856f0c
Compare
|
@adam-fowler The sourcekit-lsp PR got merged just a few hours back. Can you review this PR now? |
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilises the newly introduced
GetReferenceDocumentRequestto resolve the contents of macro expansion obtained fromPeekDocumentRequestthrough a new scheme.This change doesn't cause any behavioural changes facing the user.
The
GetReferenceDocumentRequestimplemented in sourcekit-lsp allows it to not create temporary files whenever it makes aPeekDocumentRequest.References:
Accompanying PR in sourcekit-lsp repository: swiftlang/sourcekit-lsp#1567
Expansion of Swift Macros in Visual Studio Code - Google Summer Of Code 2024
@lokesh-tr @ahoppen @adam-fowler