Remove last trace of TSCUtility
#1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
force-pushed
the
fatally-shot
branch
from
9c5fd38 to
29c2d72
Compare
|
@swift-ci please test |
artemcm
approved these changes
Jan 26, 2023
|
Ugh, this is uncovering new dependencies on TSCUtility that we didn't see before. We have a number of uses of |
Replace use of `Diagnostic.fatalError` with a `SwiftDriver.Diagnostics.errorsEmitted` type which removes the final reference to `TSCUtility` in the actual shipping code. References within the test suite may remain for now.
compnerd
force-pushed
the
fatally-shot
branch
from
29c2d72 to
2c37f31
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of
Diagnostic.fatalErrorwith aSwiftDriver.Diagnostics.errorsEmittedtype which removes the final reference toTSCUtilityin the actual shipping code. References within the test suite may remain for now.