Document specially integrated modules and integration process. #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
force-pushed
the
integration-doc
branch
2 times, most recently
from
5b94359 to
80f4fd8
Compare
|
@rxwei and I talked offline about this, we will be meeting up tomorrow or next week to discuss this proposal. |
rxwei
force-pushed
the
integration-doc
branch
2 times, most recently
from
d66f0fa to
28a1b29
Compare
milseman
reviewed
Feb 18, 2022
rxwei
force-pushed
the
integration-doc
branch
from
28a1b29 to
80f4fd8
Compare
|
@swift-ci please test |
milseman
approved these changes
Feb 28, 2022
| | `_MatchingEngine` | `SwiftCompilerSources/Sources/ExperimentalRegex` and `stdlib/public/_MatchingEngine` | | ||
| | `_CUnicode` | `stdlib/public/_StringProcessing` | | ||
| | `_StringProcessing` | `stdlib/public/_StringProcessing` | | ||
|
|
There was a problem hiding this comment.
I think this is good for an initial integration doc, but I do think we'll want some CMake, perhaps in the Swift repo, that would add or remove certain sub-folders for the stdlib, like the engine itself.
| - Do not modify the existing ABI between the regular expression parser and the Swift compiler unless absolutely necessary. | ||
| - Always minimize the number of lockstep integrations, i.e. when apple/swift-experimental-string-processing and apple/swift have to change together. | ||
| - In `_StringProcessing`, do not write fully qualified references to symbols in `_CUnicode`, and always wrap `import _CUnicode` in a `#if canImport(_CUnicode)`. This is because `_CUnicode` is built as part of `_StringProcessing` with CMake. | ||
| - In `_MatchingEngine`, do not write fully qualified references to `_MatchingEngine` itself. This is because `_MatchingEngine` is built as `ExperimentalRegex` in `SwiftCompilerSources/` with CMake. |
There was a problem hiding this comment.
And related, we should rename it to RegexParse or something.
There was a problem hiding this comment.
I agree, but I think it is better for this document to describe the current state. We can patch it once the name has changed.
rxwei
force-pushed
the
integration-doc
branch
from
80f4fd8 to
3ab3b17
Compare
|
@swift-ci please test |
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
Feb 28, 2022
Switch to using swift/main as the integration branch for apple/swift-experimental-string-processing. Integration process documentation: swiftlang/swift-experimental-string-processing#170 Friend PR: swiftlang/swift-experimental-string-processing#192
This was referenced Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.