Update regex literal delimiters #41430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
commented
Feb 17, 2022
hamishknight
force-pushed
the
choose-your-delimiter
branch
from
15593e5 to
28b400d
Compare
rxwei
approved these changes
Feb 17, 2022
rintaro
reviewed
Feb 17, 2022
hamishknight
force-pushed
the
choose-your-delimiter
branch
from
28b400d to
9e18e87
Compare
|
@swift-ci please test |
rintaro
approved these changes
Feb 17, 2022
|
Currently pending an integration workflow change (swiftlang/swift-experimental-string-processing#170). |
|
@swift-ci please clean test |
|
We've decided to use dev/7 for this round of integration. |
rxwei
added a commit
to rxwei/swift-source-compat-suite
that referenced
this pull request
Feb 25, 2022
Update the lexing code for the replacement of the `'/.../'` and `'|...|'` delimiters with `#/.../#` and `#|...|#` respectively, in addition to allowing the `re'...'` delimiter.
rxwei
force-pushed
the
choose-your-delimiter
branch
from
9e18e87 to
611fd33
Compare
rxwei
added a commit
to swiftlang/swift-experimental-string-processing
that referenced
this pull request
Feb 25, 2022
This was uncovered when testing dev/7 against swiftlang/swift#41430.
rxwei
added a commit
to rxwei/swift-source-compat-suite
that referenced
this pull request
Feb 25, 2022
|
@swift-ci please test |
|
Ok, this PR should be ready for @shahmishal to merge. |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the lexing code for the replacement of the
'/.../'and'|...|'delimiters with#/.../#and#|...|#respectively, in addition to allowing there'...'delimiter (implemented in swiftlang/swift-experimental-string-processing#167).