Internal error. Please file a bug at https://github.com/apple/swift-package-manager/issues with this info. symlinks not supported #7081
Labels
Comments
compnerd
added a commit
to compnerd/swift-package-manager
that referenced
this issue
Nov 14, 2023
The contents of a symlink is the path to which it points. We can simply read the contents as a new path, and use `getEntry` to get the contents of the symbolic link. This implementation should also fully traverse any path that is a series of symbolic link. This does allow for a DoS attack by creating a recursive symbolic link cycle (e.g. `a` -> `b` -> `a`). Fixes: swiftlang#7081
|
@MaxDesiatov is this really Windows specific? It seems to be a generic code path, I don't see how this would be Windows. |
compnerd
added a commit
that referenced
this issue
Nov 14, 2023
The contents of a symlink is the path to which it points. We can simply read the contents as a new path, and use `getEntry` to get the contents of the symbolic link. This implementation should also fully traverse any path that is a series of symbolic link. This does allow for a DoS attack by creating a recursive symbolic link cycle (e.g. `a` -> `b` -> `a`). Fixes: #7081 Co-authored-by: Max Desiatov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If a package contains a symlink for the manifest, the package build seems to fail. Example: https://github.com/compnerd/swift-firebase/actions/runs/6836319759/job/18591096135?pr=27#logs
Expected behavior
Package should be possible to build.
Actual behavior
Package manifest fails to build.
Steps to reproduce
No response
Swift Package Manager version/commit hash
No response
Swift & OS version (output of
swift --version ; uname -a)No response
The text was updated successfully, but these errors were encountered: