SourceControl: add basic support for symlinks #7092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contents of a symlink is the path to which it points. We can simply read the contents as a new path, and use `getEntry` to get the contents of the symbolic link. This implementation should also fully traverse any path that is a series of symbolic link. This does allow for a DoS attack by creating a recursive symbolic link cycle (e.g. `a` -> `b` -> `a`). Fixes: swiftlang#7081
compnerd
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
MaxDesiatov
reviewed
Nov 14, 2023
Co-authored-by: Max Desiatov <[email protected]>
|
@swift-ci please test |
|
@swift-ci test windows |
tomerd
reviewed
Nov 14, 2023
| case .blob: | ||
| return try self.repository.readBlob(hash: hash) | ||
| default: | ||
| fatalError() |
There was a problem hiding this comment.
we should avoid using fatalError which would crash the program. see #7096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents of a symlink is the path to which it points. We can simply read the contents as a new path, and use
getEntryto get the contents of the symbolic link. This implementation should also fully traverse any path that is a series of symbolic link. This does allow for a DoS attack by creating a recursive symbolic link cycle (e.g.a->b->a).Fixes: #7081