Skip to content

Bump SwiftPM's minimum deployment target to macOS 12 #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Feb 9, 2023

It is time that we update our minimum deployment target, we haven't officially supported anything pre-12.0 since the 5.6 release.

It is time that we update our minimum deployment target, we haven't officially supported anything pre-12.0 since the 5.6 release.
@neonichu neonichu self-assigned this Feb 9, 2023
@neonichu
Copy link
Contributor Author

neonichu commented Feb 9, 2023

Draft until the CI has updated to a newer macOS.

@tomerd
Copy link
Contributor

tomerd commented Feb 28, 2023

@shahmishal @neonichu is this ready to be merged?

@shahmishal
Copy link
Member

it's currently blocked on LLDB test failures (11 test failures)

yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Mar 3, 2023
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Mar 4, 2023
@neonichu neonichu marked this pull request as ready for review April 13, 2023 03:37
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

Swift CI is running on macOS 12 now, so this should be mergable.

@MaxDesiatov
Copy link
Contributor

@swift-ci smoke test macos

MaxDesiatov added a commit to swiftlang/sourcekit-lsp that referenced this pull request Apr 13, 2023
This brings the requirements in line with those set in SwiftPM, which is a dependency of SourceKit-LSP.

New macOS requirement for SwiftPM is set in swiftlang/swift-package-manager#6138.
@MaxDesiatov
Copy link
Contributor

swiftlang/sourcekit-lsp#729

@swift-ci smoke test macos

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MaxDesiatov
Copy link
Contributor

Will need to merge swiftlang/sourcekit-lsp#729 before this one so that CI continuously passes.

MaxDesiatov added a commit to swiftlang/sourcekit-lsp that referenced this pull request Apr 13, 2023
This brings the requirements in line with those set in SwiftPM, which is a dependency of SourceKit-LSP.

New macOS requirement for SwiftPM is set in swiftlang/swift-package-manager#6138.
@neonichu neonichu merged commit 5d7314a into main Apr 13, 2023
@neonichu neonichu deleted the bump-minimum-deployment-target branch April 13, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants