-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Bump SwiftPM's minimum deployment target to macOS 12 #6138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is time that we update our minimum deployment target, we haven't officially supported anything pre-12.0 since the 5.6 release.
Draft until the CI has updated to a newer macOS. |
@shahmishal @neonichu is this ready to be merged? |
it's currently blocked on LLDB test failures (11 test failures) |
@swift-ci please smoke test |
Swift CI is running on macOS 12 now, so this should be mergable. |
@swift-ci smoke test macos |
This brings the requirements in line with those set in SwiftPM, which is a dependency of SourceKit-LSP. New macOS requirement for SwiftPM is set in swiftlang/swift-package-manager#6138.
@swift-ci smoke test macos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Will need to merge swiftlang/sourcekit-lsp#729 before this one so that CI continuously passes. |
This brings the requirements in line with those set in SwiftPM, which is a dependency of SourceKit-LSP. New macOS requirement for SwiftPM is set in swiftlang/swift-package-manager#6138.
It is time that we update our minimum deployment target, we haven't officially supported anything pre-12.0 since the 5.6 release.