Skip to content

Bump minimum required tools-version to 5.7 #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Mar 2, 2023

This will require the CI to update the installed tools to at least 5.7

@neonichu neonichu self-assigned this Mar 2, 2023
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Mar 3, 2023
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Mar 4, 2023
@neonichu neonichu force-pushed the bump-tools-version branch from bb703a6 to c097246 Compare March 6, 2023 21:57
@neonichu neonichu marked this pull request as ready for review March 6, 2023 21:57
@neonichu
Copy link
Contributor Author

neonichu commented Mar 6, 2023

@swift-ci please smoke test

@neonichu neonichu enabled auto-merge (squash) March 6, 2023 21:57
@neonichu
Copy link
Contributor Author

neonichu commented Mar 6, 2023

<unknown>:0: error: missing required module 'ucrt'

cc @shahmishal @compnerd is this an infra failure?

@compnerd
Copy link
Member

compnerd commented Mar 6, 2023

@neonichu no, that is a change that went in today; it sounds like there is a sync issue? We now need to pass in -vfsoverlay ... as we are no longer modifying the Visual Studio installation.

@compnerd
Copy link
Member

compnerd commented Mar 6, 2023

@neonichu ugh, I think that the merge dropped some of the changes? The ASN1 and certificates builds are missing the flags I think.

@compnerd
Copy link
Member

compnerd commented Mar 6, 2023

swiftlang/swift#64157 should fix that, sorry about that!

@tomerd
Copy link
Contributor

tomerd commented Mar 7, 2023

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Mar 7, 2023

@swift-ci please smoke test windows

@neonichu neonichu merged commit a8ed614 into main Mar 9, 2023
@compnerd compnerd deleted the bump-tools-version branch March 26, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants