Update minimum deployment target to macOS 13 #7313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to delete some existing backwards compatibility code.
neonichu
requested review from
bnbarham,
MaxDesiatov and
tomerd
as code owners
neonichu
commented
Feb 2, 2024
| @@ -13,8 +13,6 @@ | |||
| import Basics | |||
| import XCTest | |||
|
|
|||
| /// Netrc feature depends upon `NSTextCheckingResult.range(withName name: String) -> NSRange`, | |||
| /// which is only available in macOS 10.13+ at this time. | |||
There was a problem hiding this comment.
This comment seems like something that was here explaining an availability or #if statement, but that doesn't exist here anymore.
|
We should also be able to use |
|
@swift-ci please test |
bnbarham
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to delete some existing backwards compatibility code.