Revert "Support macros when cross-compiling" #7349
Conversation
This reverts commit a0b25d3.
DougGregor
requested review from
bnbarham,
MaxDesiatov and
tomerd
as code owners
|
@swift-ci please test |
|
@MaxDesiatov the swift-syntax "Examples" package is failing to build with this error: /home/build-user/swift-syntax/Examples/Tests/MacroExamples/Implementation/ComplexMacros/DictionaryIndirectionMacroTests.swift:13:8: error: no such module 'MacroExamplesImplementation' |
|
I think I can come up with a proper fix for this quickly and we can avoid reverting this 🙏 |
`assertMacroExpansion` requires macros to be compiled for target platform and evaluated in-process. We can't handle the case of indirect macro dependencies cleanly, those will be still compiled for the host. Supersedes #7349.
|
I have a fix that doesn't require a revert for it here #7350 |
`assertMacroExpansion` requires macros to be compiled for target platform and evaluated in-process. We can't handle the case of indirect macro dependencies cleanly, those will be still compiled for the host. Supersedes #7349. This doesn't contain tests to expedite the fix and unblock broken CI jobs, but I've verified locally that test products of the `Examples` package in `apple/swift-syntax` repo can be built successfully and these tests all pass.
|
That error is no longer reproducible for me locally when running SwiftPM on the |
|
As this accumulated conflicts, I'm closing it in favor of a bigger revert in #7352 |
`assertMacroExpansion` requires macros to be compiled for target platform and evaluated in-process. We can't handle the case of indirect macro dependencies cleanly, those will be still compiled for the host. Supersedes swiftlang#7349. This doesn't contain tests to expedite the fix and unblock broken CI jobs, but I've verified locally that test products of the `Examples` package in `apple/swift-syntax` repo can be built successfully and these tests all pass.
`assertMacroExpansion` requires macros to be compiled for target platform and evaluated in-process. We can't handle the case of indirect macro dependencies cleanly, those will be still compiled for the host. Supersedes swiftlang#7349. This doesn't contain tests to expedite the fix and unblock broken CI jobs, but I've verified locally that test products of the `Examples` package in `apple/swift-syntax` repo can be built successfully and these tests all pass.
Reverts #7118. It is causing the swift-syntax Examples to fail to build. See https://ci.swift.org/job/oss-swift-incremental-RA-macos/4247/