Switch to the "Swift" diagnostic style as the default #71722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are checking the printed outpout of the diagnostic formatter in ways that change with the Swift formatter, but are not consequential.
These tests are using FileCheck to check the result of diagnostic formatting in ways that don't match the new formatter. Force the old formatter or, where possible, generalize so that they match both formatters.
The old diagnostic formatter would crash on some Fix-Its involving Unicode characters. The new one does not.
DougGregor
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
hamishknight,
rintaro,
zoecarver,
hyp,
egorzhdan,
artemcm,
ktoso and
a team
as code owners
|
@swift-ci please test |
Azoy
approved these changes
Feb 19, 2024
|
Python on Windows seems unhappy with some of the Unicode we are producing: |
Some versions of Python are unhappy with the Unicode the new diagnostic formatter produces. For now, disable in one of the Python scripts where we detect this.
ahoppen
reviewed
Feb 19, 2024
| @@ -2,5 +2,12 @@ | |||
| // RUN: not %target-swift-frontend -typecheck %s 2> %t.errors | |||
| // RUN: %FileCheck %s <%t.errors | |||
| // CHECK-NOT: Program arguments: | |||
|
|
|||
| // Note: extra newlines below ensure that context printing doesn't show the | |||
There was a problem hiding this comment.
I think this comment would be useful in the other tests that have multiple newlines as well. I was quite confused by them at first.
|
swiftlang/swift-package-manager#7349 @swift-ci please test |
|
swiftlang/swift-package-manager#7368 @swift-ci please test |
|
@DougGregor Hahaha you finally fixed that compiler_crasher! Nice! Only one left... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "Swift" diagnostic style has been enabled for standard library builds for quite a while now, and we've addressed all of the issues we've seen with it. Turn it on by default.
There are a significant number of FileCheck-based tests in our test suite that are checking for the precise output of the LLVM diagnostic formatter, and do not pass with the new Swift one. Generalize those tests that are easy to generalize, so they pass with both, and force others to use the older formatter with
-diagnostic-style llvm. If we need to switch back, we can leave the tests and switch the default back easily enough.This resolves one old compiler crasher due to some poor Unicode handling in the older diagnostic formatter.