Skip to content

Enable tests on Linux CI #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaxDesiatov opened this issue Nov 9, 2023 · 0 comments · Fixed by #146
Closed

Enable tests on Linux CI #45

MaxDesiatov opened this issue Nov 9, 2023 · 0 comments · Fixed by #146
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Nov 9, 2023 •
edited
Loading

We haven't tested our workflows fully on Linux yet. This should be fixed and enabled on CI by modifying the Utilities/test.sh script accordingly.
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Nov 9, 2023
@MaxDesiatov MaxDesiatov self-assigned this Nov 9, 2023
@MaxDesiatov MaxDesiatov added the good first issue Good for newcomers label Nov 10, 2023
@MaxDesiatov MaxDesiatov mentioned this issue Nov 10, 2023
Merged
@MaxDesiatov MaxDesiatov removed their assignment Nov 10, 2023
MaxDesiatov added a commit that referenced this issue Nov 21, 2023
@MaxDesiatov
Cancel tasks when receiving a SIGINT signal (#47)
908b6f9 
This adds a dependency on the `ServiceLifecly` product from https://github.com/swift-server/swift-service-lifecycle.

Had to add a manual call to `withTaskCancellationHandler` in the current `Shell` implementation to propagate `SIGINT` to child processes on task cancellation.

I've also made `Engine` initializer and `shutDown` method internal, using `withEngine` pattern instead, which fixes shut down bugs that came up with task cancellation.

Also fixed `ArchitectureMappingTests.swift` not building due to recent changes and macOS CI being broken, while tests are temporarily disabled on Linux CI (tracked in #45, reenabled in a subsequent PR).

Resolves rdar://116204896.
@euanh euanh mentioned this issue Jan 26, 2024
Merged
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Nov 8, 2024
@euanh
tests: Run tests on Linux CI
7e463a4 
The EndToEnd tests cannot currently be run:

* they deadlock when run under `swift test` (swiftlang#143)
* the CI requires the use of an HTTP proxy to download from the
  Internet, but SDK generator does not support proxies (swiftlang#145)

The tests are conditionally compiled only on Linux, so we must skip
them in CI.

Fixes swiftlang#45
@euanh euanh mentioned this issue Nov 8, 2024
Merged
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Nov 8, 2024
@euanh
QueryEngine: Calculate stable hashes for Foundation.URL and Foundatio…
542d515 
…nEssentials.URL

Until Swift 6.0, the fully-qualified name of the URL type was
`Foundation.URL`.  After the adoption of FoundationEssentials, the
name changed to `FoundationEssentials.URL`.  This difference causes
the hashes to change, so for backwards compatibility we pin the
type name to `Foundation.URL`.

Fixes swiftlang#45
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Nov 8, 2024
@euanh
tests: Run tests on Linux CI
96eecce 
The EndToEnd tests cannot currently be run:

* they deadlock when run under `swift test` (swiftlang#143)
* the CI requires the use of an HTTP proxy to download from the
  Internet, but SDK generator does not support proxies (swiftlang#145)

The tests are conditionally compiled only on Linux, so we must skip
them in CI.

Fixes swiftlang#45
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Nov 8, 2024
@euanh
QueryEngine: Calculate stable hashes for Foundation.URL and Foundatio…
fd3aef5 
…nEssentials.URL

Until Swift 6.0, the fully-qualified name of the URL type was
`Foundation.URL`.  After the adoption of FoundationEssentials, the
name changed to `FoundationEssentials.URL`.  This difference causes
the hashes to change, so for backwards compatibility we pin the
type name to `Foundation.URL`.

Fixes swiftlang#45
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Nov 8, 2024
@euanh
tests: Run tests on Linux CI
1c609f3 
The EndToEnd tests cannot currently be run:

* they deadlock when run under `swift test` (swiftlang#143)
* the CI requires the use of an HTTP proxy to download from the
  Internet, but SDK generator does not support proxies (swiftlang#145)

The tests are conditionally compiled only on Linux, so we must skip
them in CI.

Fixes swiftlang#45
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Nov 8, 2024
@euanh
tests: Run tests on Linux CI
f76acec 
The EndToEnd tests cannot currently be run:

* they deadlock when run under `swift test` (swiftlang#143)
* the CI requires the use of an HTTP proxy to download from the
  Internet, but SDK generator does not support proxies (swiftlang#145)

The tests are not compiled on macOS, but this commit marks
them with `XCTSkip` so they are not run on Linux either.

Fixes swiftlang#45
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Nov 8, 2024
@euanh
tests: Run tests on Linux CI
95b78b4 
The EndToEnd tests cannot currently be run:

* they deadlock when run under `swift test` (swiftlang#143)
* the CI requires the use of an HTTP proxy to download from the
  Internet, but SDK generator does not support proxies (swiftlang#145)

The tests are not compiled on macOS, but this commit marks
them with `XCTSkip` so they are not run on Linux either.

Future commits will loosen these restrictions.

Fixes swiftlang#45
@euanh euanh closed this as completed in #146 Nov 8, 2024
@euanh euanh closed this as completed in 71e2d79 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Run tests on Linux CI euanh/swift-sdk-generator
1 participant
@MaxDesiatov