tests: Test that an SDK can be rebuilt without cleaning up #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
First commit only adds the test, to verify it runs in CI and fails. |
euanh
force-pushed
the
fix-nonincremental-rebuilds
branch
from
df7a2f8 to
15bb533
Compare
|
@swift-ci test |
|
CI isn't currently running tests - see #45. |
euanh
force-pushed
the
fix-nonincremental-rebuilds
branch
from
15bb533 to
0db79f6
Compare
|
@swift-ci test |
euanh
force-pushed
the
fix-nonincremental-rebuilds
branch
from
0db79f6 to
c5ccbe5
Compare
|
@swift-ci test |
euanh
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #68, rebuilding a RHEL SDK bundle has failed with the following error unless the bundle is first deleted:
This is because the condition check around the cleanup logic was inverted when the check was moved into
LinuxRecipe.swift.Before:
https://github.com/apple/swift-sdk-generator/blob/5428358a282d53e4d714b90c0348a293cca0038d/Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator%2BEntrypoint.swift#L51-L52
After:
https://github.com/apple/swift-sdk-generator/blob/b94744f2b3d89511145072d907a18c9ea6aa5578/Sources/SwiftSDKGenerator/SwiftSDKRecipes/LinuxRecipe.swift#L129-L130
This PR adds a test which tries to build an SDK twice without cleaning up in between.