Recipe: Get rid of all use of LinuxDistribution in SDKGenerator
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
yt/generator-move-linux-specific-things
branch
2 times, most recently
from
8166246 to
b766a06
Compare
This is a preparation for moving `linuxDistribution` into recipe.
kateinoigakukun
force-pushed
the
yt/generator-move-linux-specific-things
branch
from
b766a06 to
58b8181
Compare
|
@swift-ci test |
euanh
approved these changes
Jan 15, 2024
MaxDesiatov
reviewed
Jan 15, 2024
Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator+Entrypoint.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jan 15, 2024
Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator+Entrypoint.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jan 15, 2024
MaxDesiatov
reviewed
Jan 15, 2024
MaxDesiatov
reviewed
Jan 15, 2024
MaxDesiatov
reviewed
Jan 15, 2024
|
@swift-ci test |
MaxDesiatov
pushed a commit
that referenced
this pull request
Jan 29, 2024
Since #68, rebuilding a RHEL SDK bundle has failed with the following error unless the bundle is first deleted: ``` Error: The file “lib64” couldn’t be saved in the folder “rhel-ubi9.sdk” because a file with the same name already exists. ``` This is because the condition check around the cleanup logic was inverted when the check was moved into `LinuxRecipe.swift`. #### Before: https://github.com/apple/swift-sdk-generator/blob/5428358a282d53e4d714b90c0348a293cca0038d/Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator%2BEntrypoint.swift#L51-L52 #### After: https://github.com/apple/swift-sdk-generator/blob/b94744f2b3d89511145072d907a18c9ea6aa5578/Sources/SwiftSDKGenerator/SwiftSDKRecipes/LinuxRecipe.swift#L129-L130 This PR adds a test which tries to build an SDK twice without cleaning up in between.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinuxDistribution,Versionsconfiguration, andDownloadableArtifactsare quite Linux specific and they are generally not required to build Swift SDK. The latter two might be reusable for other platforms, but it would be better to use from each SDK recipe instead of using it in SDK generator directly.