Add a conditional compilation flag to verify token choices #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
approved these changes
Feb 13, 2023
|
@swift-ci Please test |
Verification of token choice is currently causing assertion failures where the list of expected token choices in the syntax tree doesn't match those the parser generates. I’d still like to get the verification code into `main` so I can conditionally enable it locally while working on the issues, so add it behind a conditional compilation flag.
ahoppen
force-pushed
the
ahoppen/validate-token-choices
branch
from
78a7fa1 to
bbf5297
Compare
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Mar 31, 2023
…-choices Add a conditional compilation flag to verify token choices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification of token choice is currently causing assertion failures where the list of expected token choices in the syntax tree doesn't match those the parser generates.
I’d still like to get the verification code into
mainso I can conditionally enable it locally while working on the issues, so add it behind a conditional compilation flag.