-
Notifications
You must be signed in to change notification settings - Fork 439
Cherry-pick PRs from main
to release/5.9
#1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable assertions in Release+Assert builds of earlyswiftsyntax
Replace `assert` by `precondition` in most places
…-choices Add a conditional compilation flag to verify token choices
Add missing CMakeLists.txt exclude
…-expression-error
…sage-for-identifier-editor-placeholder
If no explicit highlight range was given, highlight the node the diagnostic is anchored at instead of highlighting nothing
…stic-for-missing-left-brace-or-if-after-else
Fix warning in code gen
…-comparison-in-default-value
Parse versions as three integer tokens
…ng-and-trailing-equal
…matches Fix multiple cases where the parser produced token kinds that didn’t match the token kinds in the syntax node definitions
…n-macos-only Only output number of executed instructions in `swift-parser-cli` on macOS
@swift-ci Please test |
DougGregor
approved these changes
Mar 31, 2023
To the editor placeholder we also need to cherry pick in the swift repo. If that also have a 5.9 branch |
@swift-ci Please test |
Thanks for keeping track of things. I forgot about that. I opened swiftlang/swift#64805. |
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the following PRs to
release/5.9
, effectively bringingrelease/5.9
up-to-date withmain
swift-parser-cli
on macOS #1462=
with unbalanced whitespaceendOfFile
inadvance
#14571.0e2
for the major version) and hex integer literals for the patch versionswitch
& for-each expression andwhile
&if
condition error #1429#if
and makes cherry-picking a lot easier because this touches a lot. Thus, low riskassert
byprecondition
in most places #1427precondition
s) now, I think we will never have the guts to do so. So let’s get it in now while we still have time until the real release.Release+Assert
builds, not plain release builds.