Skip to content

Add diagnostic for unexpected second identifier #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add diagnostic for unexpected second identifier #1382

merged 1 commit into from
Apr 12, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Mar 2, 2023 •
edited
Loading

Part of fixing an TODOs in here: #1373

I just wanna ask if I'm on the right path.

@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 2 times, most recently from d2937be to a920e3c Compare March 2, 2023 14:55
kimdv
kimdv commented Mar 2, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 3 times, most recently from ec8a8c5 to df146f0 Compare March 2, 2023 15:25
@kimdv kimdv marked this pull request as ready for review March 3, 2023 08:27
@kimdv kimdv requested a review from ahoppen as a code owner March 3, 2023 08:27
ahoppen
ahoppen reviewed Mar 7, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 2 times, most recently from ecacd47 to f965d6a Compare March 10, 2023 11:45
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 2 times, most recently from 73bd9e8 to f532d90 Compare March 17, 2023 08:21
@ahoppen ahoppen mentioned this pull request Mar 17, 2023
Open
58 tasks
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 7 times, most recently from 38bd131 to 582a48f Compare March 20, 2023 11:43
ahoppen
ahoppen reviewed Mar 20, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 3 times, most recently from ec13f3d to 618d2aa Compare March 24, 2023 20:35
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 2 times, most recently from c4b11b6 to a68db20 Compare March 28, 2023 16:00
ahoppen
ahoppen reviewed Mar 28, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 2 times, most recently from d2190c7 to 3370247 Compare March 30, 2023 11:30
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 5 times, most recently from 29fcf4d to 2e81b0a Compare April 2, 2023 09:18
@kimdv kimdv mentioned this pull request Apr 2, 2023
Merged
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 2 times, most recently from 2209414 to 6fd09dd Compare April 9, 2023 17:24
@kimdv kimdv requested a review from ahoppen April 9, 2023 17:24
@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch 2 times, most recently from 1d7d077 to 320d973 Compare April 11, 2023 07:17
ahoppen
ahoppen approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me. Just one request for a comment

@kimdv kimdv force-pushed the kimdv/Add-diagnostic-for-unexpected-second-identifier branch from 320d973 to 54a278e Compare April 12, 2023 06:02
@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

@swift-ci please test windows

1 similar comment
@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

@swift-ci please test windows

@kimdv kimdv enabled auto-merge April 12, 2023 10:06
@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

@swift-ci please test windows

1 similar comment
@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

@swift-ci please test windows

@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

It looks like windows is failing, can't figure out why?
Can you help @compnerd ?

@compnerd
Copy link
Member

compnerd commented Apr 12, 2023 •
edited
Loading

From the build log:

C:\Users\swift-ci\jenkins\workspace\swift-syntax-PR-windows\llvm-project\lldb\source\Plugins\TypeSystem\Swift\SwiftASTContext.cpp(2907): error C2664: 'swift::ASTContext *swift::ASTContext::get(swift::LangOptions &,swift::TypeCheckerOptions &,swift::SILOptions &,swift::SearchPathOptions &,swift::ClangImporterOptions &,swift::symbolgraphgen::SymbolGraphOptions &,swift::SourceManager &,swift::DiagnosticEngine &,llvm::IntrusiveRefCntPtr<llvm::vfs::OutputBackend>,std::function<bool (llvm::StringRef,bool)>)': cannot convert argument 9 from 'bool (__cdecl *)(llvm::StringRef,bool)' to 'llvm::IntrusiveRefCntPtr<llvm::vfs::OutputBackend>'

Looks like somehow a bad change was merged into LLDB or more likely a backport? I think that there is a branch mismatch.

@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

@swift-ci please test windows

@kimdv kimdv merged commit 52a8828 into swiftlang:main Apr 12, 2023
@kimdv kimdv deleted the kimdv/Add-diagnostic-for-unexpected-second-identifier branch April 12, 2023 18:31
kimdv added a commit to kimdv/swift-syntax that referenced this pull request Apr 12, 2023
@kimdv
Merge pull request swiftlang#1382 from kimdv/kimdv/Add-diagnostic-for…
deea82d 
…-unexpected-second-identifier

Add diagnostic for unexpected second identifier
@kimdv kimdv mentioned this pull request Apr 13, 2023
Merged
kimdv added a commit to kimdv/swift-syntax that referenced this pull request Apr 18, 2023
@kimdv
Merge pull request swiftlang#1382 from kimdv/kimdv/Add-diagnostic-for…
8c8bd6b 
…-unexpected-second-identifier

Add diagnostic for unexpected second identifier
kimdv added a commit to kimdv/swift-syntax that referenced this pull request Apr 23, 2023
@kimdv
Merge pull request swiftlang#1382 from kimdv/kimdv/Add-diagnostic-for…
e3e36fa 
…-unexpected-second-identifier

Add diagnostic for unexpected second identifier
kimdv added a commit to kimdv/swift-syntax that referenced this pull request May 18, 2023
@kimdv
Merge pull request swiftlang#1382 from kimdv/kimdv/Add-diagnostic-for…
61ad113 
…-unexpected-second-identifier

Add diagnostic for unexpected second identifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimdv @compnerd @ahoppen