Skip to content

[5.9] Add diagnostic for unexpected second identifier #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

[5.9] Add diagnostic for unexpected second identifier #1521

merged 1 commit into from
May 19, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 12, 2023 •
edited
Loading

  • Explanation: If there is two identifiers separated by a space we diagnosed with a wrong diagnostic. This should come with a better diagnostic to helper the developer
  • Scope: Parsing of identifiers
  • Risk: Low, improves diagnostic
  • Testing: CI didn’t find any issues
  • Issue: N/A
  • Reviewer: @ahoppen on Add diagnostic for unexpected second identifier #1382

@kimdv kimdv requested a review from ahoppen as a code owner April 12, 2023 19:44
@kimdv
Copy link
Contributor Author

kimdv commented Apr 12, 2023

@swift-ci please test

@kimdv kimdv requested a review from bnbarham April 18, 2023 19:03
@kimdv kimdv force-pushed the kimdv/chery-pick-unexpected-second-identifier branch from deea82d to 8c8bd6b Compare April 18, 2023 19:49
@kimdv
Copy link
Contributor Author

kimdv commented Apr 18, 2023

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/chery-pick-unexpected-second-identifier branch from 8c8bd6b to 2579d96 Compare April 23, 2023 17:50
kimdv
kimdv commented Apr 23, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/chery-pick-unexpected-second-identifier branch from 2579d96 to e3e36fa Compare April 25, 2023 07:20
@kimdv
Copy link
Contributor Author

kimdv commented Apr 25, 2023

@swift-ci please test

@kimdv
Merge pull request swiftlang#1382 from kimdv/kimdv/Add-diagnostic-for…
61ad113 
…-unexpected-second-identifier

Add diagnostic for unexpected second identifier
@kimdv kimdv force-pushed the kimdv/chery-pick-unexpected-second-identifier branch from e3e36fa to 61ad113 Compare May 18, 2023 08:38
@kimdv
Copy link
Contributor Author

kimdv commented May 18, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented May 18, 2023

@swift-ci please test windows

1 similar comment
@kimdv
Copy link
Contributor Author

kimdv commented May 18, 2023

@swift-ci please test windows

@ahoppen ahoppen merged commit 665b4ab into swiftlang:release/5.9 May 19, 2023
@kimdv kimdv deleted the kimdv/chery-pick-unexpected-second-identifier branch May 19, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimdv @bnbarham @ahoppen