Skip to content

Fix warning in code gen #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix warning in code gen #1422

merged 2 commits into from
Mar 28, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Mar 19, 2023

No description provided.

@kimdv kimdv requested a review from ahoppen as a code owner March 19, 2023 10:04
.package(url: "https://github.com/apple/swift-syntax.git", revision: "94b9021a2e461fc9a4b3bda6f4734119b52e8094"),
.package(url: "https://github.com/apple/swift-syntax.git", revision: "55349f8019fb129781af3f988011b20b66989664"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updated the swift-syntax version. Even there is noting new, just so we don't get too far behind.

@kimdv
Copy link
Contributor Author

kimdv commented Mar 19, 2023

@swift-ci please test

@kimdv kimdv force-pushed the kimdv/fix-warning branch from 80621cc to 229d9bf Compare March 24, 2023 20:27
@kimdv
Copy link
Contributor Author

kimdv commented Mar 24, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Mar 24, 2023

@ahoppen I'm not sure if the new generated files is a mis in a previous PR?

But can we, some how, avoid missing code generation in the future?
You mentioned the Ci don't have access to the internet.

But can we, in the CI refer to a local swift-syntax package?
I think the builder is now, OK stable?

@ahoppen
Copy link
Member

ahoppen commented Mar 27, 2023

@ahoppen I'm not sure if the new generated files is a mis in a previous PR?

Oh, I think that was my fault. I probably forgot to re-generate the files in one of my previous PRs.

But can we, some how, avoid missing code generation in the future?
You mentioned the Ci don't have access to the internet.

But can we, in the CI refer to a local swift-syntax package?
I think the builder is now, OK stable?

Hmm, an interesting idea could be if CodeGeneration would refer to HEAD instead of a fixed commit of the parent repository. That way you can work locally and basically have a stable base for your CodeGeneration changes, i.e. changes you make in your working copy don’t immediately impact whether CodeGeneration compiles. And only after you commit do you need to adjust CodeGeneration. That could work.

@kimdv kimdv merged commit 74c544e into swiftlang:main Mar 28, 2023
@kimdv kimdv deleted the kimdv/fix-warning branch March 28, 2023 05:50
kimdv added a commit to kimdv/swift-syntax that referenced this pull request Mar 28, 2023
ahoppen pushed a commit to ahoppen/swift-syntax that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants