-
Notifications
You must be signed in to change notification settings - Fork 439
[Macros] Support code item macro expansion #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -85,12 +85,13 @@ internal enum PluginToHostMessage: Codable { | |||
|
|||
enum MacroRole: String, Codable { | |||
case expression | |||
case freeStandingDeclaration | |||
case declaration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm renaming this because macro roles typically don't include "freestanding" vs "attached". Does this need a corresponding change on the compiler side? If so I can revert this. @rintaro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not need a corresponding change because I believe freeStandingDeclaration
and expression
aren't actually used in expandFreestandingMacro
message. But yes, we should sync this file with swift repo one.
But you/we can do it later (after you merge this PR)
@swift-ci please test |
Huh, how's this possible. It runs fine locally /Users/ec2-user/jenkins/workspace/swift-syntax-PR-macOS/branch-main/swift-syntax/Tests/SwiftSyntaxMacrosTest/MacroSystemTests.swift:1024:5: error: cannot find 'AssertMacroExpansion' in scope
AssertMacroExpansion(
^~~~~~~~~~~~~~~~~~~~
error: fatalError |
@swift-ci please test |
@swift-ci please test |
Test Case '-[SwiftSyntaxMacrosTest.MacroSystemTests testUnwrap]' started.
Test Case '-[SwiftSyntaxMacrosTest.MacroSystemTests testUnwrap]' passed (0.008 seconds). Both |
@swift-ci please clean test |
@swift-ci please test |
@swift-ci please test |
@swift-ci please test windows |
1 similar comment
@swift-ci please test windows |
No description provided.