Skip to content

Add diagnostic for comparison in default value #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Mar 25, 2023

No description provided.

@kimdv kimdv requested a review from ahoppen as a code owner March 25, 2023 19:55
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@ahoppen
Copy link
Member

ahoppen commented Mar 27, 2023

@swift-ci Please test

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-comparison-in-default-value branch from 7b2e3f7 to e0d23c1 Compare March 28, 2023 05:14
@kimdv
Copy link
Contributor Author

kimdv commented Mar 28, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Mar 28, 2023

@swift-ci please test windows

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-comparison-in-default-value branch from e0d23c1 to 7c2aac7 Compare March 28, 2023 07:03
@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-comparison-in-default-value branch from 7c2aac7 to 0643ff3 Compare March 28, 2023 07:06
@kimdv
Copy link
Contributor Author

kimdv commented Mar 28, 2023

@swift-ci please test

@kimdv kimdv merged commit 33e4b33 into swiftlang:main Mar 28, 2023
@kimdv kimdv deleted the kimdv/add-diagnostic-for-comparison-in-default-value branch March 28, 2023 10:18
ahoppen pushed a commit to ahoppen/swift-syntax that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants