Skip to content

Add diagnostic for array type #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Mar 26, 2023

No description provided.

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch 3 times, most recently from 2870c41 to f543d98 Compare March 26, 2023 17:37
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one comment on where the diagnostic should be anchored.

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch 4 times, most recently from 1dc25b3 to fe4b7f7 Compare April 2, 2023 09:31
@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch from fe4b7f7 to c87e977 Compare April 2, 2023 10:02
@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch 2 times, most recently from aee0635 to 83d60db Compare April 13, 2023 10:43
@kimdv
Copy link
Contributor Author

kimdv commented Apr 13, 2023

@swift-ci please test

@kimdv kimdv marked this pull request as ready for review April 13, 2023 10:48
@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch from 83d60db to 4182d27 Compare April 14, 2023 09:12
@kimdv
Copy link
Contributor Author

kimdv commented Apr 14, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 15, 2023

@swift-ci please test Windows

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch from 4182d27 to 1421a90 Compare April 15, 2023 16:01
@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch from 1421a90 to 701f2db Compare April 18, 2023 10:40
@kimdv
Copy link
Contributor Author

kimdv commented Apr 18, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 18, 2023

@swift-ci please test windows

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch from 701f2db to 65eb783 Compare April 19, 2023 14:57
@kimdv
Copy link
Contributor Author

kimdv commented Apr 19, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 19, 2023

@swift-ci please test windows

@kimdv
Copy link
Contributor Author

kimdv commented Apr 20, 2023

@ahoppen can you review this again?

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch from 65eb783 to 7a0068e Compare April 20, 2023 17:43
@kimdv
Copy link
Contributor Author

kimdv commented Apr 21, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 21, 2023

@swift-ci please test windows

@kimdv
Copy link
Contributor Author

kimdv commented Apr 21, 2023

Waiting for #1558 to be merged

@kimdv kimdv force-pushed the kimdv/add-diagnostic-for-wrong-type branch from 7a0068e to 0aa8321 Compare April 22, 2023 12:22
@kimdv
Copy link
Contributor Author

kimdv commented Apr 22, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Apr 22, 2023

@swift-ci please test windows

2 similar comments
@kimdv
Copy link
Contributor Author

kimdv commented Apr 22, 2023

@swift-ci please test windows

@kimdv
Copy link
Contributor Author

kimdv commented Apr 22, 2023

@swift-ci please test windows

@kimdv kimdv merged commit c9e4d07 into swiftlang:main Apr 23, 2023
@kimdv kimdv deleted the kimdv/add-diagnostic-for-wrong-type branch April 23, 2023 08:46
kimdv added a commit to kimdv/swift-syntax that referenced this pull request Apr 23, 2023
…-wrong-type

Add diagnostic for array type
kimdv added a commit to kimdv/swift-syntax that referenced this pull request May 22, 2023
…-wrong-type

Add diagnostic for array type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants