[5.9] Add diagnostic for array type #1573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
changed the title
|
@swift-ci please test |
…-wrong-type Add diagnostic for array type
kimdv
force-pushed
the
kimdv/cherry-pick-add-diagnostic-for-wrong-type
branch
from
bb21fec to
3fd77d6
Compare
|
@swift-ci please test |
ahoppen
requested changes
May 22, 2023
Comment on lines
+1073
to
+1074
| if self.at(.rightSquareBracket) { | ||
| let (unexpectedBeforeRSquareBracket, rightSquareBracket) = self.expect(.rightSquareBracket) |
There was a problem hiding this comment.
Actually looking at this code again, I think we should only do this recovery if the ] is not on a new line. And I also realized that we could write this as follows. If you could incorporate those changes in main, that would be great.
Suggested change
| if self.at(.rightSquareBracket) { | |
| let (unexpectedBeforeRSquareBracket, rightSquareBracket) = self.expect(.rightSquareBracket) | |
| if let rightSquareBracket = self.consume(if: .rightSquareBracket) { |
And since I just found another thing to comment on and this PR only provide value in a very niche use case, I’d prefer not to cherry-pick it to 5.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.