Only output number of executed instructions in swift-parser-cli on macOS
#1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…macOS `libproc.h` is not available on iOS and I’m not sure how it behaves on Linux. Since `swift-parser-cli` is only a testing utility, take the safe approach and only output the number of executed instructions on macOS.
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 29, 2023
| @@ -21,3 +30,8 @@ uint64_t getInstructionsExecuted() { | |||
| } | |||
| return 0; | |||
| } | |||
| #else | |||
| uint64_t getInstructionsExecuted() { | |||
There was a problem hiding this comment.
Would be nice to see if we can do something cross platform here, but fine for now I suppose 🤷
There was a problem hiding this comment.
Yeah, I agree. But let’s wait to see if a need comes up first since this is just a testing utility anyway.
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Mar 31, 2023
…n-macos-only Only output number of executed instructions in `swift-parser-cli` on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libproc.his not available on iOS and I’m not sure how it behaves on Linux. Sinceswift-parser-cliis only a testing utility, take the safe approach and only output the number of executed instructions on macOS.