Skip to content

Default to separating tokens by a space in BasicFormat #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 21, 2023

Instead of having to opt into separating tokens by spaces, assume that all tokens need to be separated by spaces and explicitly opt-out of space separation of tokens.

This allows us to assert that for each assertParse test without errors, we produce the same tree by formatting it using BasicFormat

@ahoppen
Copy link
Member Author

ahoppen commented Apr 21, 2023

@swift-ci Please test

ahoppen added 2 commits April 22, 2023 08:04
Instead of having to opt into separating tokens by spaces, assume that all tokens need to be separated by spaces and explicitly opt-out of space separtion of tokens.
…e same tree by formatting it using BasicFormat
@ahoppen ahoppen force-pushed the ahoppen/basic-format-3 branch from 819f38a to cf70c5b Compare April 22, 2023 15:05
@ahoppen ahoppen changed the title Default to separating tokens by a space in BasicFormat 🚥 #1568 Default to separating tokens by a space in BasicFormat Apr 22, 2023
@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Apr 22, 2023

@swift-ci Please test Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant