[5.9] Update BasicFormat #1576
Merged
[5.9] Update BasicFormat #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/5.9/update-basic-format
branch
from
f245da3 to
78c2fe4
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/5.9/update-basic-format
branch
from
78c2fe4 to
a3ff9b4
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
DougGregor
approved these changes
Apr 25, 2023
With the new BasicFormat, these cases will be formatted weirdly, so I want to update them now.
This re-writes the implementation of BasicFormat once again to better handle user-indented code. Co-authored-by: Ben Barham <[email protected]>
This mostly improves performance by calling `previousToken`, `nextToken`, and `firstToken` less often.
When a token node is modified, we would not add its arena as a child to the new arena. This is unsafe because the newly created token might still have its text stored in the original arena.
Fix wrong diagnostic for generics
Instead of having to opt into separating tokens by spaces, assume that all tokens need to be separated by spaces and explicitly opt-out of space separtion of tokens. # Conflicts: # Sources/SwiftParserDiagnostics/DiagnosticExtensions.swift # Tests/SwiftParserTest/VariadicGenericsTests.swift # Tests/SwiftParserTest/translated/AvailabilityQueryUnavailabilityTests.swift # Tests/SwiftParserTest/translated/DiagnoseDynamicReplacementTests.swift
…e same tree by formatting it using BasicFormat
ahoppen
force-pushed
the
ahoppen/5.9/update-basic-format
branch
from
a3ff9b4 to
2057d63
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks the following PRs to release/5.9, updating BasicFormat to a new version that produces source code which represents the same syntax tree when re-parsed for all passing
assertParsetest.