Skip to content

[NFC] Preparations to address the «Rename to getName?» TODO on ValueDecl::getFullName #30606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2020
Merged

[NFC] Preparations to address the «Rename to getName?» TODO on ValueDecl::getFullName #30606

merged 2 commits into from
Apr 1, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Mar 24, 2020 •
edited
Loading

@jckarter pinging you as the one who added the TODO in a30e1b4 ... 6 years ago.

  • Replace FuncDecl::getName & EnumElementDecl::getName with ValueDecl::getBaseIdentifier
  • Collapse all indirect accesses equivalent to ValueDecl::getBaseIdentifier

Upcoming

  • Rename getFullName() to getName() on ValueDecl & MissingMemberDecl

@AnthonyLatsis AnthonyLatsis requested a review from jckarter March 24, 2020 09:33
@AnthonyLatsis AnthonyLatsis changed the title [NFC] Address «Rename to getName?» TODO on ValueDecl::getFullName [NFC] Address the «Rename to getName?» TODO on ValueDecl::getFullName Mar 24, 2020
@jckarter
Copy link
Contributor

It might be good to phase this in as two separate changes, one to change getName to getBaseIdentifier, wait a bit for that to settle, then rename getFullName to getName, so that other patches in flight don't accidentally end up calling the wrong one all of a sudden.

@AnthonyLatsis
Copy link
Collaborator Author

Ah, good point, let us do it.

@AnthonyLatsis AnthonyLatsis changed the title [NFC] Address the «Rename to getName?» TODO on ValueDecl::getFullName [NFC] Preparations to address the «Rename to getName?» TODO on ValueDecl::getFullName Mar 25, 2020
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Mar 25, 2020 •
edited
Loading

Oh no, this needs a lldb change as well.

AnthonyLatsis added a commit to AnthonyLatsis/llvm-project that referenced this pull request Mar 25, 2020
@AnthonyLatsis
[Swift] Replace calls to FuncDecl::getName & EnumElementDecl::getName…
5714497 
… with ValueDecl::getBaseIdentifier for swiftlang/swift#30606
@AnthonyLatsis AnthonyLatsis mentioned this pull request Mar 25, 2020
Merged
@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#971

@swift-ci please smoke test macOS platform

@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#971

@swift-ci please smoke test Linux

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Mar 26, 2020 •
edited
Loading

@jckarter Are you OK with the changes?

P.S. Since I can only trigger CI on this repository, I will need some assistance over at swiftlang/llvm-project#971 if we agree on landing this.

@jckarter
Copy link
Contributor

Looks good to me. Let me kick off testing on the associated PR too.

@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#971

@swift-ci please smoke test

@jckarter
Copy link
Contributor

@CodaFi any other feedback before we merge this?

CodaFi
CodaFi approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away

@AnthonyLatsis
Copy link
Collaborator Author

Should we smoke test on either side in case anyone added a new call site in the past couple of days?

@jckarter
Copy link
Contributor

swiftlang/llvm-project#971

@swift-ci Please smoke test

@jckarter
Copy link
Contributor

@swift-ci Please smoke test Linux

@CodaFi
Copy link
Contributor

CodaFi commented Mar 31, 2020

swiftlang/llvm-project#971

@swift-ci Please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#971

@swift-ci please test Windows

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Mar 31, 2020 •
edited
Loading

Windows doesn't seem to be listening

Edit: Windows bot is failing because it apparently doesn't know how to test across repositories.

@AnthonyLatsis
Copy link
Collaborator Author

Ready to merge?

@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#971

@swift-ci Please smoke test

@CodaFi
Copy link
Contributor

CodaFi commented Apr 1, 2020

⛵️

@CodaFi CodaFi merged commit 630d0f6 into swiftlang:master Apr 1, 2020
@AnthonyLatsis AnthonyLatsis deleted the rename-getfullname branch April 1, 2020 16:18
@AnthonyLatsis AnthonyLatsis mentioned this pull request Apr 23, 2020
Merged
@AnthonyLatsis AnthonyLatsis mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

@jckarter jckarter Awaiting requested review from jckarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnthonyLatsis @jckarter @CodaFi