Skip to content

AST: Rename getFullName -> getName on ValueDecl & MissingMemberDecl #31224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Apr 23, 2020

Follow-up to #30606

Now that FuncDecl::getName and EnumElementDecl::getName have been replaced with ValueDecl::getBaseIdentifier, we can rename ValueDecl::getFullName to getName() and thereby address the targeted FIXME.

@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#1107

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis requested a review from jckarter April 23, 2020 02:38
@CodaFi
Copy link
Contributor

CodaFi commented Apr 23, 2020

(Oh, it's cross-repo, ignore me)

@jckarter
Copy link
Contributor

Looks good, thanks for seeing this through @AnthonyLatsis! Since this is just a rename, and we wouldn't want to deal with churn merging across branches, we probably want this in the swift-5.3-branch too once it lands in master.

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 24, 2020

Since this is just a rename, and we wouldn't want to deal with churn merging across branches, we probably want this in the swift-5.3-branch too once it lands in master.

Makes sense. Do we have a relevant 5.3 branch in the llvm-project repo?

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 24, 2020

@jckarter Also, I need someone to shepherd the PRs for me since the change is cross-repo. Thanks!

jckarter added a commit to swiftlang/llvm-project that referenced this pull request Apr 24, 2020
@jckarter jckarter merged commit b4c7a7e into swiftlang:master Apr 24, 2020
@jckarter
Copy link
Contributor

@AnthonyLatsis Sounds good! Pulling this into release/5.3 in the swift repo and swift/release/5.3 on the llvm-project repo should do the job for the 5.3 branch.

@AnthonyLatsis AnthonyLatsis deleted the rename-getfullname-2 branch April 24, 2020 20:22
adrian-prantl pushed a commit to swiftlang/llvm-project that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants