-
Notifications
You must be signed in to change notification settings - Fork 10.5k
AST: Rename getFullName -> getName on ValueDecl & MissingMemberDecl #31224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
(Oh, it's cross-repo, ignore me) |
Looks good, thanks for seeing this through @AnthonyLatsis! Since this is just a rename, and we wouldn't want to deal with churn merging across branches, we probably want this in the |
Makes sense. Do we have a relevant 5.3 branch in the llvm-project repo? |
@jckarter Also, I need someone to shepherd the PRs for me since the change is cross-repo. Thanks! |
[Swift] AST: Rename getFullName -> getName for swiftlang/swift#31224
@AnthonyLatsis Sounds good! Pulling this into |
(cherry picked from commit 1d4e7ca)
Follow-up to #30606
Now that
FuncDecl::getName
andEnumElementDecl::getName
have been replaced withValueDecl::getBaseIdentifier
, we can renameValueDecl::getFullName
togetName()
and thereby address the targeted FIXME.