Skip to content

AST: Assert we were given a type parameter in GenericSignatureImpl::requiresClass #31515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2020
Merged

AST: Assert we were given a type parameter in GenericSignatureImpl::requiresClass #31515

merged 1 commit into from
May 9, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

Doing the absolute minimum here to ease progression.

@AnthonyLatsis
Copy link
Collaborator Author

Let us see if anything hits the assert

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis requested a review from jckarter May 3, 2020 13:48
@CodaFi
Copy link
Contributor

CodaFi commented May 3, 2020

@swift-ci test

@CodaFi
Copy link
Contributor

CodaFi commented May 3, 2020

@swift-ci test source compatibility

@AnthonyLatsis
Copy link
Collaborator Author

@CodaFi is the source compat job expected not to show any details on failures?

@theblixguy
Copy link
Collaborator

I think you can access the logs from Status -> Build Artifacts

@AnthonyLatsis
Copy link
Collaborator Author

Neat, thank you!

@CodaFi
Copy link
Contributor

CodaFi commented May 4, 2020

Oh, the release and debug builders both hit a weird internal failure. I suspect there's either a file system race somewhere deep in the build, or they've run out of space. Let's try again.

@swift-ci test source compatibility

@CodaFi
Copy link
Contributor

CodaFi commented May 4, 2020

@swift-ci test Windows

@AnthonyLatsis
Copy link
Collaborator Author

Oh, the release and debug builders both hit a weird internal failure

Did the release builder not crash on generating SIL for an opaque type property in SwiftMovie?

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test source compatibility debug

2 similar comments
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test source compatibility debug

@CodaFi
Copy link
Contributor

CodaFi commented May 8, 2020

@swift-ci please test source compatibility debug

@AnthonyLatsis
Copy link
Collaborator Author

Yay!

@CodaFi
Copy link
Contributor

CodaFi commented May 9, 2020

⛵

@CodaFi CodaFi merged commit c70dce0 into swiftlang:master May 9, 2020
@AnthonyLatsis AnthonyLatsis mentioned this pull request May 11, 2020
Merged
@AnthonyLatsis AnthonyLatsis deleted the assert-type-param-requires-class branch May 12, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter Awaiting requested review from jckarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnthonyLatsis @CodaFi @theblixguy