GenericSignatureImpl: Assert we were given type parameters in getSuperclassBound & conformsToProtocol #31712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rclassBound & conformsToProtocol
AnthonyLatsis
commented
May 11, 2020
| @@ -456,8 +457,7 @@ GenericSignatureImpl::getConformsTo(Type type) { | |||
| } | |||
|
|
|||
| bool GenericSignatureImpl::conformsToProtocol(Type type, ProtocolDecl *proto) { | |||
There was a problem hiding this comment.
This method is crying to be renamed to requiresProtocol despite the FIXME it contains.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Sandbox issue @swift-ci please test source compatibility |
|
@swift-ci please test source compatibility |
CodaFi
approved these changes
May 11, 2020
|
🍄 |
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
May 20, 2020
…s with type param. assertions
AnthonyLatsis
added a commit
that referenced
this pull request
May 21, 2020
GenericSignatureImpl, #31712: Plug remaining relevant methods with type param. assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #31515